Add gocd integration about zulip HOT 11 CLOSED

Opened #70 with some notes on how to add an integration if anyone's interested.

from zulip.

Hello all,

I am currently working on implementing this feature request. Here are some questions / status etc...

@fire what kind of functionality is important to you? How does your team utilize Go? I am unsure what kind of data to be used in the payload for the test fixture.

I will submit a PR once I have the basic functionality working.

from zulip.

@corykitchens Hi there and thanks for working on this! It might help you to look at the Zulip-Jenkins integration as a guide - as this option suggests, I'm guessing teams would like to use a Zulip integration to be notified when (for instance) a build fails, or a build that had previously failed has just succeeded. I took a quick look at the GoCD docs and I'd guess that Zulip users might also want to be notified if a task, job, or stage has failed, or if a stage needs manual approval to proceed.

Am deferring to @fire of course, but giving you some thoughts in case they are useful.

from zulip.

I am not using zulip anymore, but it would go along the lines of build notifications and maybe triggering and restarting stages in gocd.

Looking at what the Jenkin plugin did is good.

There's also api documents at https://api.go.cd/current/

Maybe I could get zulip running again. I lost interest when the iphone app didn't allow signin from custom installs of zulip. https://github.com/zulip/zulip-ios/issues/2

from zulip.

PR #798

I've created a pull request to demonstrate the WIP for the Go webhook integration.
I have created fixture data that resembles that of a simple build notification. I have created the view function, sh api_gocd_webhook which takes the json object and sends the message to the specified stream. My test, sh test_send_build_status_pass passes with the fixture data.

I do have a few questions

1. In terms of naming scheme, I've seen both Go and Go.cd. I'm wondering which is the correct name to use for naming purposes.
2. For the documentation, each integration features a logo. Is there a public repository out there that hosts these images including Go.cd? I didn't want to copy/paste some copyrighted image from some unknown source.

And of course feel free for tips/thoughts on moving forward.

from zulip.

1. I would call it Go.cd --- "Go" is I think somewhat ambiguous (e.g. there's a programming language by the same name).
2. We've been adding to static/images/integrations/ the logos of the products being integrated with.

from zulip.

All,

Just wanted to give you an update on this issue.

-I have changed my code to reflect @timabbott 's suggestions based on #789
-I've spent the past week getting a deeper understanding of the Go.cd application in order to better support the needs of the users

• As I continue to work on this, I will be flying out to Portland to attend the PyCon conference. I'll have further updates + a pull request after the conference ends. Hope to see you all there

from zulip.

@corykitchens See you at the PyCon sprints, I hope!

from zulip.

This integration should be pretty doable by following the Zulip integration guide: https://zulip.readthedocs.io/en/latest/integration-guide.html

I closed the existing PR since I think we should be able to just redo this from scratch pretty quickly. It'd be a good exercise for anyone looking to learn about writing Zulip incoming webhook integrations.

from zulip.

@zulipbot claim

from zulip.

Hello @Balaji2198, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

from zulip.