Memory Size without Units about go-facter HOT 6 CLOSED

I made a sketch of this here: jtopjian@9149610

Maybe it would be cleaner to just standardize on _bytes?

from go-facter.

Hello @jtopjian,

I'm glad you like it and thank you. I must admit/say, though, that it really doesn't do much, if anything at all. It came to be as a POC/counter to running PuppetLab's facter in privileged Docker Container for the purpose of facter beat. Unfortunately, former solution has won :)

As for referenced projects, they look alright and way advanced to me. Wouldn't it be worthy to replace whatever they're using as backend to gather system information with gopsutil instead?

As for referenced commit, it looks good to me(maybe comment here and there, eg. it seems there are too many "swapfree" :) ). If anything, I would for sure keep _mb as PuppetLab's facter has it. My $0.02USD/compatibility wise. Emitting more facts, eg. _gb, _bytes sounds alright to me.
Anyway, I'll be happy to accept PR!

Once again, thanks.

from go-facter.

Wouldn't it be worthy to replace whatever they're using as backend to gather system information with gopsutil instead?

I debated this for a day or two after I found go-facter and ended up doing it a few hours before you replied. :)

I'd still be happy to add this feature, but if you're no longer using this, either, then no big deal!

from go-facter.

It might be better decision than reinventing wheel all over again :) I know this is somewhat anti-pattern, I could've been famous and rich and whatnot by spinning this project off :D

No, I'm not using it and I'm not sure if anybody does, although I've noticed it has 4 stars which is surprising :)

If you have time and will, please, finish it. It's almost done, so why not to add more functionality? Or I can checkout your fork and add cleanup on top of your commit(to retain credit you deserve).

from go-facter.

If you have time and will, please, finish it.

Sounds like a plan to me! I'll fix the swapfree part and open a PR 😄

from go-facter.

PR has been merged. Thank you for contribution, @jtopjian! :)

from go-facter.