Code Monkey home page Code Monkey logo

Comments (2)

davidstosik avatar davidstosik commented on June 11, 2024

This for loop here breaks on white spaces and ends up calling zcompile space/.antigenrc (whereas the complete path was /antigen space/.antigenrc).

antigen/bin/antigen.zsh

Lines 1866 to 1867 in 64de2dc

for rsrc in $ANTIGEN_CHECK_FILES; do
zcompile $rsrc

(Update: actually the loop works because $ANTIGEN_CHECK_FILES is an array? 🤔 )

Here's another thing that shows the problem:

# cat /root/.antigen/.resources 
/root/.zshrc
space/.antigenrc

The /antigen part in /antigen space/.antigenrc's path got mangled.

from antigen.

davidstosik avatar davidstosik commented on June 11, 2024

Here's the part to blame (interestingly includes a TODO 😅 ):

antigen/bin/antigen.zsh

Lines 1918 to 1921 in 64de2dc

# TODO Fix: Fuzzy match shoud be replaced by a sane way to determine it.
if [[ $#funcfiletrace -ge 6 ]]; then
ANTIGEN_CHECK_FILES+=("${${funcfiletrace[6]%:*}##* }")
fi

> trace="/antigen space/.antigenrc:2"
> echo ${${trace%:*}##* }
space/.antigenrc

(Honestly no idea what to do with this. 😅 )

Alright, I had to read some doc, but here I am. (It's super hard to find the right piece of doc by the way!)

  • ${trace%:*} looks like the ${name%pattern} expansion syntax:

    If the pattern matches the end of the value of name, then substitute the value of name with the matched portion deleted; otherwise, just substitute the value of name. In the first form, the smallest matching pattern is preferred; in the second form, the largest matching pattern is preferred.

    This is meant to delete the :2 portion of the trace line.

  • ${path##* } looks like the ${name##pattern} expansion syntax:

    If the pattern matches the beginning of the value of name, then substitute the value of name with the matched portion deleted; otherwise, just substitute the value of name. In the first form, the smallest matching pattern is preferred; in the second form, the largest matching pattern is preferred.

    This seems to delete "everything until the last space at the beginning of the string".

It's hard to understand whether the expansion that deletes until the last space is required or not, or why it's there. It was original introduced in this commit, and both the commit and associated PR lack details that could explain why it's necessary... 🤔

For what it's worth, this diff seemed to fix it for my very simplistic setup (I can't imagine it won't break anything though 😰):

diff --git i/bin/antigen.zsh w/bin/antigen.zsh
index aeba2a7..f0d83d9 100644
--- i/bin/antigen.zsh
+++ w/bin/antigen.zsh
@@ -1917,7 +1917,7 @@ EOC
       fi
       # TODO Fix: Fuzzy match shoud be replaced by a sane way to determine it.
       if [[ $#funcfiletrace -ge 6 ]]; then
-        ANTIGEN_CHECK_FILES+=("${${funcfiletrace[6]%:*}##* }")
+        ANTIGEN_CHECK_FILES+=("${funcfiletrace[6]%:*}")
       fi
     fi
 
diff --git i/src/ext/cache.zsh w/src/ext/cache.zsh
index 248638d..85f1d04 100644
--- i/src/ext/cache.zsh
+++ w/src/ext/cache.zsh
@@ -133,7 +133,7 @@ EOC
       fi
       # TODO Fix: Fuzzy match shoud be replaced by a sane way to determine it.
       if [[ $#funcfiletrace -ge 6 ]]; then
-        ANTIGEN_CHECK_FILES+=("${${funcfiletrace[6]%:*}##* }")
+        ANTIGEN_CHECK_FILES+=("${funcfiletrace[6]%:*}")
       fi
     fi

from antigen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.