Code Monkey home page Code Monkey logo

Comments (24)

babarot avatar babarot commented on May 28, 2024

I appreciate your detailed report. I want to fix its problem with you.

First, you should create a minimum zshrc something like below, please try zplug on it.

# minimum zshrc

source ~/.zplug/zplug
zplug "b4b4r07/zplug"
zplug check || zplug install

zplug load --verbose

I need to know about it in detail and then to reproduce because I use tmux and reattach-to-user-namespace too but that problem does not occur.

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

Upon changing my .zshrc and opening a new shell, I get another error I meant to open an issue for:

Installing...  b4b4r07/zplug
__version_requirement:10: bad math expression: operator expected at `Git-50'
Installed!     b4b4r07/zplug    (3.66s)
 ==> Installed all plugins to /Users/felix/.zplug/repos, successfully!
zplug: total wall-time 3.669167 sec.
iMac%

However, it does not crash! Interesting. I will enable plugins one by one and try to find the culprit

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

I keep my dotfiles on github by the way, here's my .zshrc.

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

So, I have changed my .zshrc to:

if [[ -f ~/.zplug/zplug ]]; then
    source ~/.zplug/zplug
    zplug "b4b4r07/zplug"

    # Triaging
    zplug "b5b4r07/enhancd", at:v1, of:enhancd.sh
    zplug "tarruda/zsh-autosuggestions"
    zplug "uvaes/fzf-marks"

    zplug check || zplug install
    zplug load --verbose
fi

and I get this output:

Installing...  b5b4r07/enhancd
__version_requirement:10: bad math expression: operator expected at `Git-50'
Installed!     b5b4r07/enhancd              (2.81s)
 ==> Installed all plugins to /Users/felix/.zplug/repos, successfully!
zplug: total wall-time 2.815381 sec.
  Loaded uvaes/fzf-marks/fzf-marks.plugin.zsh
  Loaded tarruda/zsh-autosuggestions/autosuggestions.plugin.zsh
  Loaded tarruda/zsh-autosuggestions/autosuggestions.zsh
  Loaded tarruda/zsh-autosuggestions/completion-client.zsh

  Loaded tarruda/zsh-autosuggestions/completion-server-init.zsh

Note that it gets stuck at this point and won't progress. Also my computer has slowed down to a crawl, even after closing iTerm altogether. That was another thing I meant to report.

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

I have no choice but to reboot now, I cannot even open a new terminal or the activity monitor. Every letter I type in here takes seconds to appear.

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

Alright, I had to reboot, everything's back to normal. I did get a chance to see the Activity monitor, though. There must have been at least 50 zsh instances and for some reason activity monitor does not let you kill multiple processes at once. And opening emacs took too long to change my .zshrc, so I could not start a terminal to fix it.

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

Ok, so that is definitely related to loading tarruda/zsh-autosuggestions. I can see the terminal title changing from zsh to rm over and over again.

from zplug.

babarot avatar babarot commented on May 28, 2024

__version_requirement:10: bad math expression: operator expected at `Git-50'

This error is related to #39.

from zplug.

babarot avatar babarot commented on May 28, 2024

And my name is not b5b4r07 but b4b4r07. Some problems were already fixed. Please update zplug and try again. e.g.,

Installing...  b5b4r07/enhancd
__version_requirement:10: bad math expression: operator expected at `Git-50'
Installed!     b5b4r07/enhancd              (2.81s)

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

Alright I did zplug update and it did not fix the git Git-50 thing, but it does load now and tmux seems to work !! It must have been fixed within the last 24 hours or so, because I did a fresh zplug install on my work machine yesterday when I made the report 👍

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

Ah, the issue is back. I have applied #40 which fixed the Git-50 math expression errors, but I have tracked down the cause of this:

if [[ -f ~/.zplug/zplug ]]; then
    source ~/.zplug/zplug
    zplug "b4b4r07/zplug"
    zplug "zsh-users/zsh-syntax-highlighting"
    zplug "plugins/vi-mode", from:oh-my-zsh
    zplug check || zplug install
    zplug load --verbose
fi

Both zsh-users/zsh-syntax-highlighting and plugins/vi-mode run fine on their own, but when combined it causes the described behaviour in tmux. It may be related to babarot/enhancd#17?

from zplug.

babarot avatar babarot commented on May 28, 2024

I have applied #40 which fixed the Git-50 math expression errors,

This error is fixed now. 1b4f1a6

Both zsh-users/zsh-syntax-highlighting and plugins/vi-mode run fine on their own, but when combined it causes the described behaviour in tmux.

Okay, I'll give it a try.

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

I found a couple of other things when trying to creating a docker image that reproduces the problem:

  • zplug does not detect missing git, it just stumbles over "command not found"
  • event with git installed, the initial install always fails (but all things seem installed):
Installing...  zsh-users/zsh-syntax-highlighting
Installing...  b4b4r07/enhancd
Installing...  robbyrussell/oh-my-zsh
Installing...  b4b4r07/zplug
Installed!     b4b4r07/zplug                            (4.32s)
Installed!     b4b4r07/enhancd                          (4.52s)
Installed!     zsh-users/zsh-syntax-highlighting        (4.88s)
Installed!     robbyrussell/oh-my-zsh                   (9.59s)
 ==> Installed to /root/.zplug/repos but failed.
zplug: total wall-time 9.604009 sec.
  Loaded robbyrussell/oh-my-zsh/oh-my-zsh.sh
  Loaded b4b4r07/enhancd/enhancd.sh
  Loaded robbyrussell/oh-my-zsh/plugins/vi-mode/vi-mode.plugin.zsh
  Loaded zsh-users/zsh-syntax-highlighting/zsh-syntax-highlighting.plugin.zsh

Also, for what it's worth, I find " ==> Installed to /root/.zplug/repos but failed." very confusing, how about "Installation completed with errors" or something like that? It's currently telling me 2 things, where it's installing and whether it's failed, one being mostly irrelevant to the user and the other one being of high importance.

from zplug.

babarot avatar babarot commented on May 28, 2024

Thank you for your report!

zplug does not detect missing git, it just stumbles over "command not found"

Now, latest zplug will detect whether git command exists or not. see also L1732-L1736 and 32ca4b5. Does that answer your question?

event with git installed, the initial install always fails (but all things seem installed):

Yes. This problem is known issue for me. All things will be installed successfully. This message and error occur when the process ID of background job has conflicted. In fact, it rarely occurs. I am going to do something about that problem, for example, not to display the error message to the user directly.

Also, for what it's worth, I find " ==> Installed to /root/.zplug/repos but failed." very confusing, how about "Installation completed with errors" or something like that?

Thanks! Sounds good to me. I will make this message clearly understandable.

from zplug.

babarot avatar babarot commented on May 28, 2024

event with git installed, the initial install always fails (but all things seem installed):

Yes. This problem is known issue for me. All things will be installed successfully. This message and error occur when the process ID of background job has conflicted. In fact, it rarely occurs. I am going to do something about that problem, for example, not to display the error message to the user directly.

oops, sorry. The cause of this problem isn't the confilct of the process ID in background jobs. I will investigate the cause with xtrace.

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

It seems like I am unable to reproduce the issue within a docker container, I have even tried my complete .zshrc and it all works. Could be sth OSX specific?

Zsh versions:

Ubuntu: zsh 5.0.2 (x86_64-pc-linux-gnu)
OSX: zsh 5.0.7 (x86_64-apple-darwin14.0.0)

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

After a zplug update just now, the tmux part of this issue seem to have vanished! It works pretty well when I create and remove a bunch of panes, so that's great. I'll try it on my work machine again. Should we consider this sorted then? I really don't know what it was that fixed it but with the most recent version of zplug it just works !! 👍

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

Just came back from holidays to my work machine, and the problem is still occurring here :S

Unfortunately, I cannot give any more information, other than that it's still OSX Mavericks (iMac).

The config above reproduces the problem for me:

if [[ -f ~/.zplug/zplug ]]; then
    source ~/.zplug/zplug
    zplug "b4b4r07/zplug"
    zplug "zsh-users/zsh-syntax-highlighting"
    zplug "plugins/vi-mode", from:oh-my-zsh
    zplug check || zplug install
    zplug load --verbose
fi

Also note that this error only occurs when using reattach-to-user-namespace (as per issue title)... I just confirmed it again.

Edit:

Note that I rm -rf ~/.zplug, and reinstalled. So it should be up-to-date.

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

So, if I put set -g remain-on-exit on in my .tmux.conf, the panes stay open and report "Pane is dead".

I find it interesting that old panes die when I create a new one.

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

Actually, it now seems that reattach-to-user-namespace has nothing to do with this... It happens also for set-option -g default-command "zsh", but not for: set-option -g default-command "bash"

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

Really, the only thing that seems to help is to take out zsh-users/syntax-highlighting. I guess I can live without it :)

from zplug.

babarot avatar babarot commented on May 28, 2024

Okay, I'll reproduce your problem.

from zplug.

NigoroJr avatar NigoroJr commented on May 28, 2024

@felixSchl Is this issue fixed/not due to zplug from what I see in the referenced issue?

from zplug.

felixSchl avatar felixSchl commented on May 28, 2024

@NigoroJr Correct. This can be closed.

from zplug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.