Comments (23)
Other thing I just noticed. When updating my manifest according to the new README i.e. when I put android:theme="app/AppTheme" on <application>
and android:theme="app/BootTheme" on <activity>
, I see the splash screen switching from app icon to the one I want and I see the 'Double Splash Screen issue' on the play console
Screen_Recording_20240131_151012_VEV.-.Test.App.mp4
If I only put android:theme="app/BootTheme" on <application
, the issue disappears
from react-native-bootsplash.
Looking back to the history of my builds on play store, it seems the double splash issue appeared when introducing this new architecture. So the is an issue with multiple res dirs on Android 14 I assume
from react-native-bootsplash.
Not able to reproduce it on Android 14:
reproduction.mp4
from react-native-bootsplash.
I see that your icon is distorted, that's probably what you are seeing here:
![Screenshot 2024-01-31 at 11 27 47](https://private-user-images.githubusercontent.com/1902323/301126884-ec9a83d8-c28c-465a-a862-412b1cb1a4fa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2MDM1ODEsIm5iZiI6MTcxNDYwMzI4MSwicGF0aCI6Ii8xOTAyMzIzLzMwMTEyNjg4NC1lYzlhODNkOC1jMjhjLTQ2NWEtYTg2Mi00MTJiMWNiMWE0ZmEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUwMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MDFUMjI0MTIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDIwZTBhODU0OTQ3MDNkMWU5YzI5N2EyMWYwNzQxMWY0MzJjZjM1ZjgwOTBlMzUwYzU3MGFhZGIyOGUxYjBkOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.j4ouOqbmvRgLDhLvrOn9WM4S72m45M1H3mbG8IIewG8)
from react-native-bootsplash.
It's only from time to time, not every time I launch the app. Can it be a Samsung thing ?
I posted this 'testapp' to not show the actual app I am working on but our logo is not distorted
from react-native-bootsplash.
Yeah, Samsung is terrible at respecting the SplashScreen API. A lot of issues are coming from them.
If you are not able to reproduce it on Pixels, I recommend you to publish the issue to https://issuetracker.google.com/issues, as we will not be able to perform magic here (the first frames are handled by the system, not your app / this library)
from react-native-bootsplash.
Ok thank you :)
To be noted that I cannot repoduce it on Android 13 even on a Samsung
So it's probably the new version of UI 6.0
from react-native-bootsplash.
Unfortunately Samsung fork a lot of Android things in OneUI, but don't provide a simulator for developers to test. I wish those phones could disappear 😅
from react-native-bootsplash.
What I find surprising is that the transition is like bad -> good (right background color) -> bad and then good
See:
![Screenshot 2024-01-31 at 12 20 17](https://private-user-images.githubusercontent.com/32574035/301141694-ec1bbaff-5249-47a8-b0cc-397fa6c6a51f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2MDM1ODEsIm5iZiI6MTcxNDYwMzI4MSwicGF0aCI6Ii8zMjU3NDAzNS8zMDExNDE2OTQtZWMxYmJhZmYtNTI0OS00N2E4LWIwY2MtMzk3ZmE2YzZhNTFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTAxVDIyNDEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAzZWYxZDg1OGFhMzIwODFkOGQ5OGE3YjcxNDc2YmMxZjM5MzU4NWQ2ZTA5Y2NkNDE0M2U1ODliYWQwYjg2NGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.DtkRy18P10RZPFd1bjf-whcyVX7ot87aBZZz_i83DKQ)
![Screenshot 2024-01-31 at 12 20 01](https://private-user-images.githubusercontent.com/32574035/301141698-33eacb7f-7836-401f-bd94-a5f769ff462c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2MDM1ODEsIm5iZiI6MTcxNDYwMzI4MSwicGF0aCI6Ii8zMjU3NDAzNS8zMDExNDE2OTgtMzNlYWNiN2YtNzgzNi00MDFmLWJkOTQtYTVmNzY5ZmY0NjJjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTAxVDIyNDEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBkYjFhNjQ3YTYxZTY1OGRmNjhhNGE2ZWFkMmQyZjY3ZjFjNmFmMDRiMDAyNjNjNzA5MmU4OTUzNzQ5NzYzNGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.5wpgWiUthT2hMFBTRhAW33MMddR-8uQDAel93xbZtz8)
![Screenshot 2024-01-31 at 12 20 31](https://private-user-images.githubusercontent.com/32574035/301141689-3667937f-c91d-4048-9e2d-a026eaedbb56.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2MDM1ODEsIm5iZiI6MTcxNDYwMzI4MSwicGF0aCI6Ii8zMjU3NDAzNS8zMDExNDE2ODktMzY2NzkzN2YtYzkxZC00MDQ4LTllMmQtYTAyNmVhZWRiYjU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTAxVDIyNDEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk3NDc4ZjRjMGZhY2ZjMjYyNWJlZWQ5MWQxM2ExYTg2Mzc2YzUyOWU4M2RhYWYwZmVlNTc5OGFhNDliNDBmZmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.4UUu9SkMkZ57iZRBm7tcjeYhpDl9wNCLa99PwWQtOBk)
![Screenshot 2024-01-31 at 12 22 13](https://private-user-images.githubusercontent.com/32574035/301141992-47ddd6bd-e9be-4b61-8cac-a12a94059149.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2MDM1ODEsIm5iZiI6MTcxNDYwMzI4MSwicGF0aCI6Ii8zMjU3NDAzNS8zMDExNDE5OTItNDdkZGQ2YmQtZTliZS00YjYxLThjYWMtYTEyYTk0MDU5MTQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTAxVDIyNDEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEzODE3NDRjNDI4ZGRmZWEyODFmNGJkYjhkOWU5NjQyM2VhNDFkNmU3YWU3NGUxM2IyMzMxNDIyOTc4MzBhZmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QQN89A9IDhk3cfqPGIZxdXA3bsBqMEJ0BW6qwLAMuno)
from react-native-bootsplash.
Could you publish the content of your android/app directory in a zip, just in case?
from react-native-bootsplash.
Do you need something specific ? I don't think I can upload the whole content publicly
from react-native-bootsplash.
Just the content of android/app
. If you can't publish it, send it to me via email (the address is available in package.json)
from react-native-bootsplash.
Just the content of
android/app
. If you can't publish it, send it to me via email (the address is available in package.json)
Done :)
from react-native-bootsplash.
@AlixH Another things that does not seems to happen on non-Samsung phones.
Just checked your dir, and it's kinda weird, you don't have a styles.xml
in res/values
, but you have one in res-core
(and also have two AndroidManifest
).
Could you tried with a normal architecture / a clean react-native app to be sure that this is indeed a bug and not an issue you introduced? Because, if the system pick the necessary resources before your app booting, how would it know it has to search in your custom named directories?
from react-native-bootsplash.
Can you explain why the two android:theme are important ? From my understanding, the one on <application>
is enough because we already define postBootSplashTheme in the styles
from react-native-bootsplash.
If set on application theme, the splash screen will be used on new activities / dialogs by default: #516
Please fix your config according to the latest comment to see if this issue is not simply related to your file architecture.
from react-native-bootsplash.
@AlixH Another things that does not seems to happen on non-Samsung phones.
Just checked your dir, and it's kinda weird, you don't have a
styles.xml
inres/values
, but you have one inres-core
(and also have twoAndroidManifest
).Could you tried with a normal architecture / a clean react-native app to be sure that this is indeed a bug and not an issue you introduced? Because, if the system pick the necessary resources before your app booting, how would it know it has to search in your custom named directories?
In build.gradle, I specify to use both directories:
sourceSets {
main {
res.srcDirs = ["src/main/res-core", "src/main/res"]
}
}
As of the manifest, AndroidManifest.xml is generated at build time by copying AndroidManifest-core.xml and simply replacing some placeholders
I will try what you said
from react-native-bootsplash.
To be precise, it occures that the issue only happens on Release builds
from react-native-bootsplash.
Makes sense actually. Your app is defining the additional res folders, but the system is not aware of them. Closing this as following the default install does not create an issue.
from react-native-bootsplash.
In the end, the only reason I intoduced res-core is because I had no solution to avoid having git changes when generating the splash screen during build with this library because it adds the splash screen background color to res/colors
This is why I opened this other issue first #504
from react-native-bootsplash.
Jut being able to specify outputDir in the command line generator would be a massive feature
from react-native-bootsplash.
Having only one res directory does not solve the issue
from react-native-bootsplash.
In the end, the only reason I intoduced res-core is because I had no solution to avoid having git changes when generating the splash screen during build with this library because it adds the splash screen background color to res/colors
generate && git checkout path/to/the/file
to reset the changes
from react-native-bootsplash.
Related Issues (20)
- Google Play Error on upgrade to v5: "java.lang.RuntimeException: Canvas: trying to use a recycled bitmap android.graphics.Bitmap@3b54910" HOT 5
- Updating README for iOS HOT 1
- Background image and linear gradient baackground color
- Splash Screen Reappears During Screen Transitions on Android HOT 10
- Crash on Android <= 9 - Attempt to invoke virtual method Drawable.isProjected() on a null object reference - solved in 5.1.2 HOT 2
- Bug when assembleeRelease HOT 1
- iOS error during debug scheme starting HOT 2
- How can i show code push progress bar in splash screen? HOT 1
- Output/Document need to manually create missing images HOT 1
- Default Android system splashscreen appears before my custom splashscreen HOT 1
- Add option to use system scheme instead of scheme returned by useColorScheme in useHideAnimation HOT 6
- 我在屏幕中间放一个logo,我还需要在屏幕底部放些文字,要怎么做呢?
- Add plugin for nx HOT 1
- splash icon disappeared in android HOT 3
- Adding android:windowBackground causes it to appear after original splash hides HOT 3
- Generated background has incorrect color HOT 6
- Generate splashscreen HOT 1
- iOS: building failed with RN 0.73 and new arch enabled HOT 3
- RN 0.74 - How to avoid `createRootViewWithBridge` HOT 1
- Small icon size on Samsung devices with Android 12 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-bootsplash.