Code Monkey home page Code Monkey logo

Comments (23)

AlixH avatar AlixH commented on June 30, 2024 3

Other thing I just noticed. When updating my manifest according to the new README i.e. when I put android:theme="app/AppTheme" on <application> and android:theme="app/BootTheme" on <activity>, I see the splash screen switching from app icon to the one I want and I see the 'Double Splash Screen issue' on the play console

Screen_Recording_20240131_151012_VEV.-.Test.App.mp4

If I only put android:theme="app/BootTheme" on <application, the issue disappears

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024 1

Looking back to the history of my builds on play store, it seems the double splash issue appeared when introducing this new architecture. So the is an issue with multiple res dirs on Android 14 I assume

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

Not able to reproduce it on Android 14:

reproduction.mp4

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

I see that your icon is distorted, that's probably what you are seeing here:

Screenshot 2024-01-31 at 11 27 47

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

It's only from time to time, not every time I launch the app. Can it be a Samsung thing ?
I posted this 'testapp' to not show the actual app I am working on but our logo is not distorted

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

Yeah, Samsung is terrible at respecting the SplashScreen API. A lot of issues are coming from them.

If you are not able to reproduce it on Pixels, I recommend you to publish the issue to https://issuetracker.google.com/issues, as we will not be able to perform magic here (the first frames are handled by the system, not your app / this library)

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

Ok thank you :)
To be noted that I cannot repoduce it on Android 13 even on a Samsung
So it's probably the new version of UI 6.0

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

Unfortunately Samsung fork a lot of Android things in OneUI, but don't provide a simulator for developers to test. I wish those phones could disappear 😅

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

What I find surprising is that the transition is like bad -> good (right background color) -> bad and then good
See:

Screenshot 2024-01-31 at 12 20 17 Screenshot 2024-01-31 at 12 20 01 Screenshot 2024-01-31 at 12 20 31 Screenshot 2024-01-31 at 12 22 13

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

Could you publish the content of your android/app directory in a zip, just in case?

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

Do you need something specific ? I don't think I can upload the whole content publicly

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

Just the content of android/app. If you can't publish it, send it to me via email (the address is available in package.json)

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

Just the content of android/app. If you can't publish it, send it to me via email (the address is available in package.json)

Done :)

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

@AlixH Another things that does not seems to happen on non-Samsung phones.

Just checked your dir, and it's kinda weird, you don't have a styles.xml in res/values, but you have one in res-core (and also have two AndroidManifest).

Could you tried with a normal architecture / a clean react-native app to be sure that this is indeed a bug and not an issue you introduced? Because, if the system pick the necessary resources before your app booting, how would it know it has to search in your custom named directories?

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

Can you explain why the two android:theme are important ? From my understanding, the one on <application> is enough because we already define postBootSplashTheme in the styles

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

If set on application theme, the splash screen will be used on new activities / dialogs by default: #516

Please fix your config according to the latest comment to see if this issue is not simply related to your file architecture.

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

@AlixH Another things that does not seems to happen on non-Samsung phones.

Just checked your dir, and it's kinda weird, you don't have a styles.xml in res/values, but you have one in res-core (and also have two AndroidManifest).

Could you tried with a normal architecture / a clean react-native app to be sure that this is indeed a bug and not an issue you introduced? Because, if the system pick the necessary resources before your app booting, how would it know it has to search in your custom named directories?

In build.gradle, I specify to use both directories:

 sourceSets {
        main {
            res.srcDirs = ["src/main/res-core", "src/main/res"]
        }
    }

As of the manifest, AndroidManifest.xml is generated at build time by copying AndroidManifest-core.xml and simply replacing some placeholders

I will try what you said

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

To be precise, it occures that the issue only happens on Release builds

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

Makes sense actually. Your app is defining the additional res folders, but the system is not aware of them. Closing this as following the default install does not create an issue.

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

In the end, the only reason I intoduced res-core is because I had no solution to avoid having git changes when generating the splash screen during build with this library because it adds the splash screen background color to res/colors
This is why I opened this other issue first #504

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

Jut being able to specify outputDir in the command line generator would be a massive feature

from react-native-bootsplash.

AlixH avatar AlixH commented on June 30, 2024

Having only one res directory does not solve the issue

from react-native-bootsplash.

zoontek avatar zoontek commented on June 30, 2024

In the end, the only reason I intoduced res-core is because I had no solution to avoid having git changes when generating the splash screen during build with this library because it adds the splash screen background color to res/colors

generate && git checkout path/to/the/file to reset the changes

from react-native-bootsplash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.