Improve parameter handling about jsvideourlparser HOT 5 CLOSED

Can you give me an example with what that happened? I got a freeze when I first added it but couldn't reproduce it again afterwards so I wasn't sure if it was still in there.

from jsvideourlparser.

Ok, me code looks like this:

project.getVideoUrl = function (url, options) {
        var videoInfo = '',
            videoUrl = '';
        if (typeof win.urlParser === 'object') {
            videoInfo = win.urlParser.parse(url);
            if (typeof videoInfo === 'object' && typeof videoInfo.provider === 'string') {
                videoUrl = win.urlParser.create({
                    videoInfo: videoInfo,
                    format: 'embed',
                    params: typeof options === 'object' && typeof options[videoInfo.provider] === 'object' ? options[videoInfo.provider] : {}
                });
            }
            if (videoUrl.length) {
                return videoUrl;
            } else {
                return false;
            }
        }
        return false;
    };

The check typeof options === 'object' is essential, otherwise it runs into a infinite loop.

from jsvideourlparser.

I can't seem to find the bug. Could you provide some test data that causes the infinite loop?

from jsvideourlparser.

Strange, I cannot reproduce it too^^ ... however, it will not hurt to check for params.length before you start the whole processing - I close this issue for now

from jsvideourlparser.

I will rewrite some parts and add more tests anyway.

from jsvideourlparser.