Code Monkey home page Code Monkey logo

Comments (6)

molnard avatar molnard commented on July 27, 2024 1

The concept makes sense. First, let's see how it should work now. According to this test, it should alternate.

https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi.Tests/UnitTests/KeyManagementTests.cs#L215

We could say it is quasi-random. So either it is or there is a bug in Wasabi.

Is it alternating for you?

from walletwasabi.

lontivero avatar lontivero commented on July 27, 2024 1

No, change scripts are not always taproot and even if that were the case 3 observations are not enough to assert anything.

from walletwasabi.

molnard avatar molnard commented on July 27, 2024

Which version of Wasabi are you using?

from walletwasabi.

kristapsk avatar kristapsk commented on July 27, 2024

Always using the same script type for change might have minor benefits, as, if change is later spent again, not going into WabiSabi coinjoin, but receiver of first tx is not a wallet supporting WabiSabi, it's harder to distinguish which was recipient address and which was change.

from walletwasabi.

nostitos avatar nostitos commented on July 27, 2024

The drawback is that one can't sync the same seed with another segwit or taproot only wallet. For example, spending on mobile.

Usually there's a privacy benefit to fuzzing the change but in the case of CJ spending it's easy to tell one get remixed and the other doesn't (unless sending to another WW). In the meantime there's a privacy gain if random or same script but there isn't if it's sending change always to taproot.

from walletwasabi.

nostitos avatar nostitos commented on July 27, 2024

The concept makes sense. First, let's see how it should work now. According to this test, it should alternate.

https://github.com/zkSNACKs/WalletWasabi/blob/master/WalletWasabi.Tests/UnitTests/KeyManagementTests.cs#L215

We could say it is quasi-random. So either it is or there is a bug in Wasabi.

Is it alternating for you?

Latest, I only checked 3 transfer as a sample all change went to taproot.

from walletwasabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.