[UI] `Add Wallet`: sometimes wallet name page is displayed at first wallet creation about walletwasabi HOT 17 CLOSED

So maybe current is ok... no need to revert for release

ACK. Get back to this after the release.

from walletwasabi.

Navigating back is not a normal workflow.

it happens (also) without navigating back
just start with empty datadir and sometimes Wallet name dialog is displayed and sometimes not

from walletwasabi.

@wieslawsoltes thanks for the hints, they were useful
fix is here #12723

from walletwasabi.

is this fixable before release?
it can be a very confusing and bad UX

from walletwasabi.

is this fixable before release?

if not, we should revert it (for the release/ until it is properly implemented)
having it randomly sometimes displayed, and sometimes not displayed is worse than having it always displayed

from walletwasabi.

@zkSNACKs/ui-team Can you take a look at this?

from walletwasabi.

@turbolay fairly mentioned that the issue doesn't occur with the normal workflow. It's only when you go back, which most users won't.
So maybe current is ok... no need to revert for release

from walletwasabi.

I cannot reproduce this issue. Win 11

from walletwasabi.

@MarnixCroes In what percentage can you repro this?

from walletwasabi.

@MarnixCroes In what percentage can you repro this?

@soosr I just tried 10 times, it happened 6 times.

from walletwasabi.

@turbolay fairly mentioned that the issue doesn't occur with the normal workflow. It's only when you go back, which most users won't.
So maybe current is ok... no need to revert for release

I was wrong here, because it does happen in normal workflow

from walletwasabi.

@MarnixCroes In what percentage can you repro this?

@soosr I just tried 10 times, it happened 6 times.

Thanks. @wieslawsoltes could you try to reproduce and debug it on your Linux?

EDIT:

Please also check on mac (I thought it was tested there).

@turbolay fairly mentioned that the issue doesn't occur with the normal workflow. It's only when you go back, which most users won't.

So maybe current is ok... no need to revert for release

I was wrong here, because it does happen in normal workflow

Navigating back is not a normal workflow.

from walletwasabi.

@MarnixCroes In what percentage can you repro this?

@soosr I just tried 10 times, it happened 6 times.

Thanks. @wieslawsoltes could you try to reproduce and debug it on your Linux?

EDIT:

Please also check on mac (I thought it was tested there).

@turbolay fairly mentioned that the issue doesn't occur with the normal workflow. It's only when you go back, which most users won't.

So maybe current is ok... no need to revert for release

I was wrong here, because it does happen in normal workflow

Navigating back is not a normal workflow.

I will try reproducing on my Linux machine.

from walletwasabi.

I can't repro on Linux Mint, did try many times

from walletwasabi.

The only place that could this happen is here:

https://github.com/zkSNACKs/WalletWasabi/blob/92e49219a06cdd8e762adbf23855d2ac9d3f7a1b/WalletWasabi.Fluent/ViewModels/AddWallet/WalletNamePageViewModel.cs#L38

1. The wallet repository has actually wallets
2. The wallet name is not valid for some reason

from walletwasabi.

The only place that could this happen is here:

https://github.com/zkSNACKs/WalletWasabi/blob/92e49219a06cdd8e762adbf23855d2ac9d3f7a1b/WalletWasabi.Fluent/ViewModels/AddWallet/WalletNamePageViewModel.cs#L38

1. The wallet repository has actually wallets
2. The wallet name is not valid for some reason

So maybe there is issue here:
https://github.com/zkSNACKs/WalletWasabi/blob/92e49219a06cdd8e762adbf23855d2ac9d3f7a1b/WalletWasabi/Wallets/WalletDirectories.cs#L48
or here:
https://github.com/zkSNACKs/WalletWasabi/blob/92e49219a06cdd8e762adbf23855d2ac9d3f7a1b/WalletWasabi/Wallets/WalletDirectories.cs#L84

from walletwasabi.

Thanks @wieslawsoltes, I will contact @MarnixCroes on Slack to debug those lines on his machine.

from walletwasabi.