Newtonsoft.Json VS System.Text.Json about walletwasabi HOT 2 CLOSED

👉Handling null values

* Newtonsoft reads the null as value, and we can edit the converter's read function as we would like to handle null.

* Microsoft instead recognizes the null value, and returns it immediately, without even calling the converters read function.[1](#user-content-fn-1%5E-64dc658316f281646fb204ab00f6232c)

This is wrong, there is a setting for it on STJ's side and I fixed it in your PR. It's documented here and it contains a nice explanation as well:

This null-handling behavior is primarily to optimize performance by skipping an extra call to the converter. In addition, it avoids forcing converters for nullable types to check for null at the start of every Read and Write method override.

To enable a custom converter to handle null for a reference or value type, override JsonConverter.HandleNull to return true, as shown in the following example:

🟡 Would replacing all of those with Microsoft Json converters would increase the performance?

Yes, it would decrease the running time and memory usage.

🟡 By a lot?

Not really.

In my mind, this is not really an argument. It depends on use cases. For startup, it gives a non-trivial speedup improvement because Adam wants to load the software in at most 400 ms.

For Backend, the argument should be "how many JSON serialization/deserializations happen" and how much CPU time/memory would be saved.

Is it worth it to burn days and weeks for some (hopefully, at least) seconds of improvements in serializing and deserializing jsons?

You tell me. IMHO, it's not really.

It is worth optimizing where it makes sense. #11840 allows precisely that. It does not force to take any specific action right now. It gives more options and that was the point.

Btw:

• Newtonsoft.JSON is not being actively developed and there is a lot of resources pouring into STJ.
• With STJ, the bet on NativeAOT, app trimming (to decrease app's size) is much better than with Newtonsoft.JSON.
• If we get rid of Newtonsoft, we would have one less dependency, which is not bad either.
• STJ likely will get faster with every release, not true for Newtonsoft.

from walletwasabi.

Useful information thx for the record. Closing it to aggregate the problem into one issue. #4223

from walletwasabi.