Replaced transactions display overpaid coinjoin fees about walletwasabi HOT 6 CLOSED

is this fixed with full-rbf?

It appears 2.0.7 fixed this issue. A user on an old version who was a part of replaced coinjoin 56c7b2fab913ada716fabc122d6e247d2270b40d6a152b1d480e1f5fcfdf215a showed that it did not drop the replaced version from his history. Upon updating to 2.0.7, he said the transaction disappeared.

from walletwasabi.

Further consideration outside of the scope of this issue - If a user merged inputs to make a payment that was replaced by a coinjoin, those inputs should be reset to anon score 1 and gain the label of the original intended recipient.

from walletwasabi.

A potential inefficient fix that I mentioned to @turbolay is to periodically do a silent rescan in the background to check for funds that might be missing from replaced transactions. However, this may needlessly consume resources, so it might be better to trigger a silent rescan whenever a user runs into these sorts of errors:

[36] INFO CoinJoinCoinSelector.SelectCoinsForRound (85) No suitable coins for this round.

CoinJoinClient.CreateRegisterAndConfirmCoinsAsync (455) Round (xxxxxxxxxxxxxxxxxxxx): xxxxxxxxxxxxxxxxxxxxx-xxx is spent according to the backend. The wallet is not fully synchronized or corrupted.

#11904

from walletwasabi.

trigger a silent rescan whenever a user runs into these sorts of errors:

cACK

We need to have UI cue that something is going on. Also information has to be saved when relaunching the software

from walletwasabi.

[36] INFO CoinJoinCoinSelector.SelectCoinsForRound (85) No suitable coins for this round.

This can easily happen without the issue in discussion.

CoinJoinClient.CreateRegisterAndConfirmCoinsAsync (455) Round (xxxxxxxxxxxxxxxxxxxx): xxxxxxxxxxxxxxxxxxxxx-xxx is spent according to the backend. The wallet is not fully synchronized or corrupted

We could put an event here, to tell the client to rescan the wallet next time it opens.
But a nicer way maybe would be to put a check in TransactionProcessor to check if the incoming Tx is double spending a coinjoin with higher fee, and if so, again invoke an event to rescan the wallet?

from walletwasabi.

is this fixed with full-rbf?

from walletwasabi.