Code Monkey home page Code Monkey logo

Comments (6)

soosr avatar soosr commented on September 23, 2024 1

It cannot be removed because there are logics that must be executed exactly at that point.
However, what we can do is:

  1. Execute the logic. (show loading spinner meanwhile)
  2. Show animated checkmark (done)
  3. Close the dialog automatically.

from walletwasabi.

MaxHillebrand avatar MaxHillebrand commented on September 23, 2024
  1. Execute the logic. (show loading spinner meanwhile)
  2. Show animated checkmark (done)
  3. Close the dialog automatically.

cACK

from walletwasabi.

yahiheb avatar yahiheb commented on September 23, 2024

It cannot be removed because there are logics that must be executed exactly at that point.

Can't those logics be executed without this dialog? When the user clicks Continue on the coinjoin strategy dialog?

from walletwasabi.

soosr avatar soosr commented on September 23, 2024

It cannot be removed because there are logics that must be executed exactly at that point.

Can't those logics be executed without this dialog? When the user clicks Continue on the coinjoin strategy dialog?

It's possible, but we don't want to do that. It has two reasons:

  • That dialog has 2 way of working as of now, one when it is in Wallet Creation flow, and another one when the user just changes the profile. Adding more logic that has nothing to do with conjoin profiles is a nogo in itself and also increases the complexity even more.
  • Having feedback about the wallet creation process is finished (or any other) is needed to avoid the "wtf what happened" moments.

from walletwasabi.

yahiheb avatar yahiheb commented on September 23, 2024

That dialog has 2 way of working as of now, one when it is in Wallet Creation flow, and another one when the user just changes the profile. Adding more logic that has nothing to do with conjoin profiles is a nogo in itself and also increases the complexity even more.

AFAIK it is agreed that we should remove/separate the coinjoin profiles from the wallet creation workflow. #8880

  • Having feedback about the wallet creation process is finished (or any other) is needed to avoid the "wtf what happened" moments.

There is no better feedback than to get the created wallet open immediately without seeing this "useless" window from a UX perspective.

Remember that the goal here is: Reducing steps until first successful receive & coinjoin is a priority ...

from walletwasabi.

soosr avatar soosr commented on September 23, 2024

That dialog has 2 way of working as of now, one when it is in Wallet Creation flow, and another one when the user just changes the profile. Adding more logic that has nothing to do with conjoin profiles is a nogo in itself and also increases the complexity even more.

AFAIK it is agreed that we should remove/separate the coinjoin profiles from the wallet creation workflow. #8880

We don't know how to do it without breaking some people's privacy, that is why it has not yet happened and we don't even know when it will.

  • Having feedback about the wallet creation process is finished (or any other) is needed to avoid the "wtf what happened" moments.

There is no better feedback than to get the created wallet open immediately without seeing this "useless" window from a UX perspective.

Remember that the goal here is: Reducing steps until first successful receive & coinjoin is a priority ...

An animating checkmark is not a step, the user has no action with it and it is actually feedback about the process finished successfully.

from walletwasabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.