Code Monkey home page Code Monkey logo

Comments (4)

yahiheb avatar yahiheb commented on July 1, 2024 1

While trying to reproduce this I got a different message, and once I clicked Ok the tx was confirmed ofc:

image

2023-08-02 11:20:56.017 [43] INFO       P2pBehavior.ProcessGetDataAsync (109)   Successfully served transaction to node ([::ffff:127.0.0.1]:37150): 07d822680947ec6767a236954f85772880c041ccead932829d31ac84d6be5fcb.
2023-08-02 11:20:56.017 [62] INFO       P2pBehavior.ProcessGetDataAsync (109)   Successfully served transaction to node ([::ffff:127.0.0.1]:37150): 07d822680947ec6767a236954f85772880c041ccead932829d31ac84d6be5fcb.
2023-08-02 11:20:56.863 [1] ERROR       CancelTransactionDialogViewModel.OnCancelTransactionAsync (79)  System.Net.Http.HttpRequestException: Bad Request
bad-txns-inputs-missingorspent:::0100000001ba187286f75018c1b9bbd8a0774c3a48e95ed176460c9684ceda964864fc7c2c0100000000fdffffff0122030000000000001600143f8d893fe197077b88e67b0ec2e76a697fceade700000000
   at WalletWasabi.Tor.Http.Extensions.HttpResponseMessageExtensions.ThrowRequestExceptionFromContentAsync(HttpResponseMessage me, CancellationToken cancellationToken) in WalletWasabi\Tor\Http\Extensions\HttpResponseMessageExtensions.cs:line 122
   at WalletWasabi.WebClients.Wasabi.WasabiClient.BroadcastAsync(String hex) in WalletWasabi\WebClients\Wasabi\WasabiClient.cs:line 147
   at WalletWasabi.WebClients.Wasabi.WasabiClient.BroadcastAsync(Transaction transaction) in WalletWasabi\WebClients\Wasabi\WasabiClient.cs:line 153
   at WalletWasabi.WebClients.Wasabi.WasabiClient.BroadcastAsync(SmartTransaction transaction) in WalletWasabi\WebClients\Wasabi\WasabiClient.cs:line 158
   at WalletWasabi.Blockchain.TransactionBroadcasting.TransactionBroadcaster.BroadcastTransactionToBackendAsync(SmartTransaction transaction) in WalletWasabi\Blockchain\TransactionBroadcasting\TransactionBroadcaster.cs:line 101
   at WalletWasabi.Blockchain.TransactionBroadcasting.TransactionBroadcaster.SendTransactionAsync(SmartTransaction transaction) in WalletWasabi\Blockchain\TransactionBroadcasting\TransactionBroadcaster.cs:line 197
   at WalletWasabi.Fluent.ViewModels.Wallets.Home.History.Features.CancelTransactionDialogViewModel.OnCancelTransactionAsync(BuildTransactionResult cancellingTransaction) in WalletWasabi.Fluent\ViewModels\Wallets\Home\History\Features\CancelTransactionDialogViewModel.cs:line 72
2023-08-02 11:21:07.598 [57] INFO       FilterProcessor.ProcessAsync (50)       Downloaded filter for block 2470378.
2023-08-02 11:21:08.276 [43] INFO       AliceClient.SignTransactionAsync (217)  Round (3e0a976e77b888b7172cacb4f9b2c5f2217daf56f84edd828b4546992f02c10a), Alice (8dce69fc-f07e-bb36-2a59-50fd67aa920c): Posted a signature.

from walletwasabi.

MaxHillebrand avatar MaxHillebrand commented on July 1, 2024 1

Here the message should be a positive one like "your transaction is already confirmed" maybe even add "without you needing to pay anything extra".

from walletwasabi.

Kruwed avatar Kruwed commented on July 1, 2024

While trying to reproduce this I got a different message, and once I clicked Ok the tx was confirmed ofc:

Here the message should be a positive one like "your transaction is already confirmed" maybe even add "without you needing to pay anything extra".

If the user is trying to cancel and the transaction is confirmed, then "Failed" seems like an appropriate message. However, you also get a "Failed" message if you are attempting to speed up a transaction at the same time the existing one got confirmed, which should be a "Success" message instead

WalletWasabi Fluent Desktop_jSA99b8S95

from walletwasabi.

soosr avatar soosr commented on July 1, 2024

In both (SpeedUp, Cancel) cases the dialog closes automatically if the original transaction got confirmed meanwhile. Catching those exceptions and displaying a different message would just increase the complexity and the benefit is neglectable. Closing.

from walletwasabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.