Code Monkey home page Code Monkey logo

Comments (5)

SuperJMN avatar SuperJMN commented on September 25, 2024 2

Just to be sure: this is about previewing over a preview, right?

  • My idea is that we have to compare 2 entities, but I wonder which entities are. After some investigation I think we will ultimately have 2 TransactionSummaries : The current one and the preview. Is this correct?
  • The preview will depend on which suggestion the user is hovering with the mouse.
  • After we have the 2 TransactionSummaries, we have to compare them and generate a sort of report.
  • With this report, in the View we can show the preview data (% and faded out elements).

Side note: Adding this feature is risky. The transaction preview VM is already too complex IMHO and we are introducing yet another moving part over the quicksand. Over the UX table it can be easier than it really is due to the big & mutable condition of this VM.

from walletwasabi.

soosr avatar soosr commented on September 25, 2024 1

Discussed on @zkSNACKs/ux-team meeting.

When the user hovers over a suggestion, the solution is to:

  • fade out the section that won't be changed
  • Put a percentage number at the end of a section that will indicate if the value becomes higher/lower
    • Orange color if we cannot decide if it is good/not good for the user (i.e.: amount, fee become higher)
    • Green color if we can surely decide if that is good for the user (i.e.: fee become lower)

UX Design:
Image

from walletwasabi.

SuperJMN avatar SuperJMN commented on September 25, 2024 1

Just to be sure: this is about previewing over a preview, right?

Yes, it is already implemented, if you hover over a suggestion, the transaction preview dialog will show the suggested transaction.

My idea is that we have to compare 2 entities, but I wonder which entities are. After some investigation I think we will ultimately have 2 TransactionSummaries : The current one and the preview. Is this correct?

Yes, it is already there.

Adding this feature is risky. The transaction preview VM is already too complex IMHO and we are introducing yet another moving part over the quicksand. Over the UX table it can be easier than it really is due to the big & mutable condition of this VM.

Depending on my answer before, do you still think it is risky?

Thanks for the clarification. After reading your answer I've changed my mind and I think it should be way easier than I initially thought.

from walletwasabi.

stale avatar stale commented on September 25, 2024

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from walletwasabi.

soosr avatar soosr commented on September 25, 2024

Just to be sure: this is about previewing over a preview, right?

Yes, it is already implemented, if you hover over a suggestion, the transaction preview dialog will show the suggested transaction.

My idea is that we have to compare 2 entities, but I wonder which entities are. After some investigation I think we will ultimately have 2 TransactionSummaries : The current one and the preview. Is this correct?

Yes, it is already there.

Adding this feature is risky. The transaction preview VM is already too complex IMHO and we are introducing yet another moving part over the quicksand. Over the UX table it can be easier than it really is due to the big & mutable condition of this VM.

Depending on my answer before, do you still think it is risky?

from walletwasabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.