Code Monkey home page Code Monkey logo

Comments (7)

soosr avatar soosr commented on September 23, 2024 2

I am planning to bring this topic up at a @zkSNACKs/ux-team meeting. Because I think what we did was not the best approach. I 100% agree that we should have as fewer messages as possible in the default music box workflow, but I also think we can have as many as we want for covering edge cases because they are not always there to cause confusion and actually they can describe better those cases which means less confusion.

With this most users would see very few messages in most cases, but we would also give clear explanations in rare edge cases if those happen.

from walletwasabi.

MarnixCroes avatar MarnixCroes commented on September 23, 2024 1

for new wallet creation UX it's definitly more confusing.
Create wallet -> deposit some corn -> "Insufficient funds eligible for coinjoin".
As a newbie user, this is a big question mark.
Waiting for confirmed funds is understandable for this

from walletwasabi.

turbolay avatar turbolay commented on September 23, 2024 1

If we are going to rollback this I believe it should be before the release, otherwise it would look ridiculous to change then rollback...

from walletwasabi.

yahiheb avatar yahiheb commented on September 23, 2024

The decision to change Waiting for confirmed funds was made after a lot of user feedback and investigations and discussions:
#10313 (comment)
#10697 (comment)

Waiting for confirmed funds is understandable in one case but confusing in many other cases like when coins are banned, so reverting this is not an option because we know already it confused users:

https://github.com/search?q=repo%3AzkSNACKs%2FWalletWasabi+Waiting+for+confirmed+funds&type=issues
https://github.com/search?q=repo%3AzkSNACKs%2FWalletWasabi+Waiting+for+confirmed+funds&type=discussions
https://www.reddit.com/r/WasabiWallet/search/?q=Waiting%20for%20confirmed%20funds&restrict_sr=1&sort=new

from walletwasabi.

Kruwed avatar Kruwed commented on September 23, 2024

On v2.0.4 RC1/Windows 10, I got the "Hurray! All your funds are private!" message while I had semi private coins that were still unconfirmed. Once the transaction confirmed, the message disappeared and the timer began again. The "Waiting for confirmed funds" message would be correct here instead:

wassabee_Vlf6MOpnpO

I don't know if this step, is necessary to reproduce the Hurray! message, but it appeared after I clicked pause and play again while the "Successful coinjoin! Continuing..." message was still in the music box from the previous round.

Related? #9887

from walletwasabi.

yahiheb avatar yahiheb commented on September 23, 2024

@Kruwed This seems to be a different one. Try to reproduce it again on master and if you can open an different issue for it.

from walletwasabi.

Kruwed avatar Kruwed commented on September 23, 2024

Fixed by #11083

from walletwasabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.