Code Monkey home page Code Monkey logo

Comments (28)

molnard avatar molnard commented on September 24, 2024 7

Dear Wasabikas,

I'm thrilled to share that v2.0.4 has achieved a successful release, and I wanted to express my heartfelt gratitude for your exceptional testing efforts.

Your meticulous testing, insightful feedback, and dedication to perfection have been instrumental in ensuring the high quality and functionality of our Wallet. Your contributions have made a significant impact, and we truly appreciate your commitment.

Thank you once again for being an integral part of our success. Looking forward to more opportunities ahead!

Best regards!

from walletwasabi.

brizik avatar brizik commented on September 24, 2024 3

@molnard @MaxHillebrand
Thanks to @MarnixCroes we managed to go through the whole Test vector list.
Found some minor discrepancies, bugs have been opened so awaiting for them to be checked and fixed by devs:

  • [VDG] Ignore whitespace to compare incoming and current content by SuperJMN in #10265
    nACK, to be fixed first: #10422

  • nACK still can repro: #10422

  • nACK, space is still accepted [VDG] CurrencyEntryBox - do not allow space by soosr in #10875

  • Improve BIP21 bitcoin: URI parser test coverage by kristapsk in #10490
    DO LATER - webcam needed

  • Added support for QR code scanning on Linux by YohDeadfall in #10461
    DO the test on Linux with webcam

  • [VDG] Coin Control - fix sorting #2 by soosr in #10255

  • nACK, Marnix created a comment: #10217

from walletwasabi.

brizik avatar brizik commented on September 24, 2024 2

Test vectors

tACK

tACK

tACK

tACK

10529_handle ctrl+C gracefully

tACK

10120_startup in Task Manager

10120_run Wasabi when computer starts_ON

tACK

10232 focus dialog

tACK

10342_wallet name displayed when many wallets selected at the same time

tACK

10194_fiat conversion added as notification

tACK

tACK

tACK

tACK

tACK

tACK

tACK

tACK

tACK, except for Search bar » Wallet section » Receive option » wording not changed still goes as "displays" instead of "display" both on the tooltip label.

change request created by @MarnixCroes to fix it: #10983

10945 Search bar_Receive_display_nACK

from walletwasabi.

adamPetho avatar adamPetho commented on September 24, 2024 2

@turbolay I explicitly made sure to throw a dummy exception like this throw new Exception("crash"); on brizik's machine.
This was my only idea how to test that PR. That's why it looks stupid.

from walletwasabi.

soosr avatar soosr commented on September 24, 2024 2

UI

nACK, to be fixed first: #10422

This was a false alarm. The issue is still fixed. They found a new one, which won't be fixed for the release.

nACK, space is still accepted [VDG] CurrencyEntryBox - do not allow space by soosr in #10875

Same for this, they found a new issue, won't be fixed for the release. #10994 (comment)

nACK, Marnix created a comment: #10217

FTR the actual issue: #10985
@SuperJMN is already working on it #11047

from walletwasabi.

adamPetho avatar adamPetho commented on September 24, 2024 2

@MarnixCroes can you please check this one? on the linus machine in the office it seemed not to be available after master check-out.

I checked it quickly on the Linux test machine in the office and it works perfectly well.

from walletwasabi.

adamPetho avatar adamPetho commented on September 24, 2024 1

I meant the above ones of my comment as discussed hardware wallet related stuff.

Sorry then. I misunderstood your comment. 😅

All Kata tests are passing!

from walletwasabi.

turbolay avatar turbolay commented on September 24, 2024 1
638FEB7B-282B-4440-A692-8C3FB2F7F1C7

What is this? Is it from #10512 @adamPetho ? The message “crash” is far from what we could call user-friendly.

This issue about Test vectors is completely unreadable, I guess it would have been great to make use of <summary><details> tags to improve a bit.

Also, your nACKs have no explanations nor reproducing steps which make it hard to understand what exact scenario was tested to work on the result. The tests vectors themselves are too superficial and have all been done while merging the corresponding PR, I see really poor value in these test vectors.

All the issues encountered were introduced by the decoupling or by rushed, not really tested features (like the privacy suggestions). For TurboSync, for example, you wrote nACK when the issue came from the privacy suggestion PRs. Encountering the problem was a side effect and luck, not thanks to the test vectors. BTW, it also shows how poorly these features were tested at the time of merging. Again for TurboSync, absolutely all the tests done were already covered by xUnit……..

IMO, our tests for the release have to go further than re-doing the basic tests developers make before merging, and instead test cross interactions between new components and changes.

The AmountDecomposer changes are a good example here because they are both critical and hard to test. We tested them individually and incrementally, but now how do they really unfold with real rounds? We could invest time to have several daemons coinjoining, then analyze and draw conclusions from these datas.

from walletwasabi.

soosr avatar soosr commented on September 24, 2024 1

nACK, Marnix created a comment: #10217

FTR the actual issue: #10985 @SuperJMN is already working on it #11047

Fixed, everything is done from UI side.

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Test vectors

tACK

10287 USD amound pasted from clipboard only 2 decimals allowed 
* Fixed USD parsing in the clipboard observer by   YohDeadfall in [Fixed USD parsing in the clipboard observer #10318](https://github.com/zkSNACKs/WalletWasabi/pull/10318)

tACK

10318 comma in amount pasted correctly 
* [VDG] Fix Send - ´To´ field cuts off some letters at bottom by   soosr in [[VDG] Fix Send - ´To´ field cuts off some letters at bottom #10372](https://github.com/zkSNACKs/WalletWasabi/pull/10372)

tACK
10372_bottom of letters fully visible

* [VDG] Fix less option sends the same amount by   soosr in [[VDG] Fix less option sends the same amount #10332](https://github.com/zkSNACKs/WalletWasabi/pull/10332)

* [VDG] Fix Amount Suggestion not showing by   SuperJMN in [[VDG] Fix Amount Suggestion not showing #10624](https://github.com/zkSNACKs/WalletWasabi/pull/10624)

nACK still can repro: #10422 (comment)

* [VDG] CurrencyEntryBox - do not allow space by   soosr in [[VDG] CurrencyEntryBox - do not allow space #10875](https://github.com/zkSNACKs/WalletWasabi/pull/10875)

nACK, space is still accepted

10875 space still allowed in Currency entry box

from walletwasabi.

turbolay avatar turbolay commented on September 24, 2024

How did you repro? I just tried on Mac and I can't either enter or paste a space.

from walletwasabi.

MarnixCroes avatar MarnixCroes commented on September 24, 2024

How did you repro? I just tried on Mac and I can't either enter or paste a space.

@turbolay paste 0 . 0 3 03 03 (Linux)

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Test vectors

tACK

10287 USD amound pasted from clipboard only 2 decimals allowed > ``` > * Fixed USD parsing in the clipboard observer by YohDeadfall in [Fixed USD parsing in the clipboard observer #10318](https://github.com//pull/10318) > ```

tACK

10318 comma in amount pasted correctly > ``` > * [VDG] Fix Send - ´To´ field cuts off some letters at bottom by soosr in [[VDG] Fix Send - ´To´ field cuts off some letters at bottom #10372](https://github.com//pull/10372) > ```

tACK 10372_bottom of letters fully visible

* [VDG] Fix less option sends the same amount by   soosr in [[VDG] Fix less option sends the same amount #10332](https://github.com/zkSNACKs/WalletWasabi/pull/10332)

* [VDG] Fix Amount Suggestion not showing by   SuperJMN in [[VDG] Fix Amount Suggestion not showing #10624](https://github.com/zkSNACKs/WalletWasabi/pull/10624)

nACK still can repro: #10422 (comment)

* [VDG] CurrencyEntryBox - do not allow space by   soosr in [[VDG] CurrencyEntryBox - do not allow space #10875](https://github.com/zkSNACKs/WalletWasabi/pull/10875)

nACK, space is still accepted

10875 space still allowed in Currency entry box

tACK, 2 coins from reused address cannot be selected separately but together

10141_2.coins.from.reused.addredd.cannot.selected.separately.but.together.webm

tACK, see video in 10141

need another wallet to test is - will try later in the office

tACK

10417 copied amount suggested in flyout

tACK

9691_escape.goes.back_1.webm
9691_escape.goes.back_2.webm

tACK

10430_tx.shield.fixed.webm

DO LATER - webcam needed

tACK

tACK

DO the test on Linux with webcam

tACK

tACK

  • Turbosync

    • Load wallet, check balance
    • Recover wallet, check balance
    • Reuse internal key, check balance

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Test vectors

tACK, shield icon is replaced by AS text in the column title

10253 AS column width fixed

nACK, Marnix created a comment: #10217 (comment)

tACK

nACK, to be fixed first: #10422

tACK
Fixed: #8111
Fixed: #10144

nACK, #9952 - crash when sorting on labels: #11010

tACK
10287 USD amound pasted from clipboard only 2 decimals allowed

* Fixed USD parsing in the clipboard observer by   YohDeadfall in [Fixed USD parsing in the clipboard observer #10318](https://github.com/[/pull/10318](https://github.com/zkSNACKs/WalletWasabi/pull/10318))

tACK
10318 comma in amount pasted correctly

* [VDG] Fix Send - ´To´ field cuts off some letters at bottom by   soosr in [[VDG] Fix Send - ´To´ field cuts off some letters at bottom #10372](https://github.com/[/pull/10372](https://github.com/zkSNACKs/WalletWasabi/pull/10372))

tACK 10372_bottom of letters fully visible

* [VDG] Fix less option sends the same amount by   soosr in [[VDG] Fix less option sends the same amount #10332](https://github.com/zkSNACKs/WalletWasabi/pull/10332)

* [VDG] Fix Amount Suggestion not showing by   SuperJMN in [[VDG] Fix Amount Suggestion not showing #10624](https://github.com/zkSNACKs/WalletWasabi/pull/10624)

nACK still can repro: #10422 (comment)

* [VDG] CurrencyEntryBox - do not allow space by   soosr in [[VDG] CurrencyEntryBox - do not allow space #10875](https://github.com/zkSNACKs/WalletWasabi/pull/10875)

nACK, space is still accepted
10875 space still allowed in Currency entry box

tACK, 2 coins from reused address cannot be selected separately but together

10141_2.coins.from.reused.addredd.cannot.selected.separately.but.together.webm

tACK, see video in 10141

need another wallet to test is - will try later in the office

tACK

10417 copied amount suggested in flyout > > * [VDG] Escape button goes back by wieslawsoltes in [[VDG] Escape button goes back #9691](https://github.com//pull/9691)

tACK

9691_escape.goes.back_1.webm
9691_escape.goes.back_2.webm

tACK

10430_tx.shield.fixed.webm

DO LATER - webcam needed

tACK

tACK

DO the test on Linux with webcam

tACK

tACK

tACK

10599 crash report wording_OK

tACK

10626 crash report tool tip_OK

  • Turbosync

    • Load wallet, check balance
    • Recover wallet, check balance
    • Reuse internal key, check balance

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Test vectors

tACK, shield icon is replaced by AS text in the column title

10253 AS column width fixed > > > * [VDG] Coin Control - fix sorting [Support TOR #2](https://github.com//issues/2) by soosr in [[VDG] Coin Control - fix sorting #2 #10255](https://github.com//pull/10255)

nACK, Marnix created a comment: #10217 (comment)

tACK

nACK, to be fixed first: #10422

tACK Fixed: #8111 Fixed: #10144

nACK, #9952 - crash when sorting on labels: #11010

tACK
10287 USD amound pasted from clipboard only 2 decimals allowed

* Fixed USD parsing in the clipboard observer by   YohDeadfall in [Fixed USD parsing in the clipboard observer #10318](https://github.com/[/pull/10318](https://github.com/zkSNACKs/WalletWasabi/pull/10318))

tACK
10318 comma in amount pasted correctly

* [VDG] Fix Send - ´To´ field cuts off some letters at bottom by   soosr in [[VDG] Fix Send - ´To´ field cuts off some letters at bottom #10372](https://github.com/[/pull/10372](https://github.com/zkSNACKs/WalletWasabi/pull/10372))

tACK 10372_bottom of letters fully visible

* [VDG] Fix less option sends the same amount by   soosr in [[VDG] Fix less option sends the same amount #10332](https://github.com/zkSNACKs/WalletWasabi/pull/10332)

* [VDG] Fix Amount Suggestion not showing by   SuperJMN in [[VDG] Fix Amount Suggestion not showing #10624](https://github.com/zkSNACKs/WalletWasabi/pull/10624)

nACK still can repro: #10422 (comment)

* [VDG] CurrencyEntryBox - do not allow space by   soosr in [[VDG] CurrencyEntryBox - do not allow space #10875](https://github.com/zkSNACKs/WalletWasabi/pull/10875)

nACK, space is still accepted
10875 space still allowed in Currency entry box

tACK, 2 coins from reused address cannot be selected separately but together
10141_2.coins.from.reused.addredd.cannot.selected.separately.but.together.webm

tACK, see video in 10141

need another wallet to test is - will try later in the office

tACK
10417 copied amount suggested in flyout

tACK
10430_tx.shield.fixed.webm

DO LATER - webcam needed

tACK

tACK

DO the test on Linux with webcam

tACK

tACK

tACK

tACK

tACK

tACK

tACK

10460 crash report shown when Tor is not running

tACK

10599 crash report wording_OK > > > * crash report: add tooltip to open GH report hyperlink by MarnixCroes in [crash report: add tooltip to open GH report hyperlink #10626](https://github.com//pull/10626)

tACK

10626 crash report tool tip_OK > > > * Transaction details > > > > > > * [VDG] Dont copy negative values on Transaction Details's amount. by jmacato in [[VDG] Dont copy negative values on Transaction Details's amount. #10207](https://github.com//pull/10207) > > > * Receive workflow > > > > > > * [VDG] Fix QR-core is cropped wrong by soosr in [[VDG] Fix QR-core is cropped wrong #10371](https://github.com//pull/10371) > > > * Make recovery words copyable by soosr in [Make recovery words copyable #10496](https://github.com//pull/10496) > > > * [VDG] Improve Unused Receive Addresses wording by soosr in [[VDG] Improve Unused Receive Addresses wording #10557](https://github.com//pull/10557) > > > * [Trivial] Fix QR Code in lowercase by SuperJMN in [[Trivial] Fix QR Code in lowercase #10816](https://github.com//pull/10816) > > > > > * Wallet screen > > > > > > * [VDG] Fix history table selection jumping by wieslawsoltes in [[VDG] Fix history table selection jumping #10231](https://github.com//pull/10231) > > > * Reduce MaxAnonScore of PrivateCoinJoinProfile for new wallets by turbolay in [Reduce MaxAnonScore of PrivateCoinJoinProfile for new wallets #10468](https://github.com//pull/10468) > > > * Wasabi daemon > > > > > > * Wasabi Daemon by lontivero in [Wasabi Daemon #10293](https://github.com//pull/10293) > > > * Start wallets automatically after daemon starts by lontivero in [Start wallets automatically after daemon starts #10532](https://github.com//pull/10532) > > > * Specify wallet in the request path by lontivero in [Specify wallet in the request path #10522](https://github.com//pull/10522) > > > * Display software version by lontivero in [Display software version #10537](https://github.com//pull/10537) > > > > > * Hardware wallet > > > > > > * PSBT workflow User friendly exception on PSBT saving by adamPetho in [User friendly exception on PSBT saving #10512](https://github.com//pull/10512) > > > * Update HWI to 2.2.1 by jmacato in [Update HWI to 2.2.1 #10185](https://github.com//pull/10185) > > > > > * Turbosync > > > > > > * Load wallet, check balance > > > * Recover wallet, check balance > > > * Reuse internal key, check balance > > > > > * CoinJoin > > > > > > * Multiple coinjoins, observer number of coins, cost, anonscore gains > > > * Feebump [RBF fee bump payment transactions  #10805](https://github.com//issues/10805) > > > * Pirvacy warnings [Alert users about risky spending behavior #8622](https://github.com//issues/8622)

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Test vectors

tACK, shield icon is replaced by AS text in the column title
10253 AS column width fixed

tACK

nACK, to be fixed first: #10422

tACK Fixed: #8111 Fixed: #10144
nACK, #9952 - crash when sorting on labels: #11010
tACK - #9952 fixed

tACK
10287 USD amound pasted from clipboard only 2 decimals allowed

* Fixed USD parsing in the clipboard observer by   YohDeadfall in [Fixed USD parsing in the clipboard observer #10318](https://github.com/[/pull/10318](https://github.com/zkSNACKs/WalletWasabi/pull/10318))

tACK
10318 comma in amount pasted correctly

* [VDG] Fix Send - ´To´ field cuts off some letters at bottom by   soosr in [[VDG] Fix Send - ´To´ field cuts off some letters at bottom #10372](https://github.com/[/pull/10372](https://github.com/zkSNACKs/WalletWasabi/pull/10372))

tACK 10372_bottom of letters fully visible

* [VDG] Fix less option sends the same amount by   soosr in [[VDG] Fix less option sends the same amount #10332](https://github.com/zkSNACKs/WalletWasabi/pull/10332)

* [VDG] Fix Amount Suggestion not showing by   SuperJMN in [[VDG] Fix Amount Suggestion not showing #10624](https://github.com/zkSNACKs/WalletWasabi/pull/10624)

nACK still can repro: #10422 (comment)

* [VDG] CurrencyEntryBox - do not allow space by   soosr in [[VDG] CurrencyEntryBox - do not allow space #10875](https://github.com/zkSNACKs/WalletWasabi/pull/10875)

nACK, space is still accepted
10875 space still allowed in Currency entry box

tACK, 2 coins from reused address cannot be selected separately but together
10141_2.coins.from.reused.addredd.cannot.selected.separately.but.together.webm

tACK, see video in 10141

need another wallet to test is - will try later in the office

tACK
10417 copied amount suggested in flyout

tACK
10430_tx.shield.fixed.webm

DO LATER - webcam needed

tACK

tACK

DO the test on Linux with webcam

tACK

tACK

tACK

tACK

tACK

tACK

tACK

10460 crash report shown when Tor is not running

tACK
10599 crash report wording_OK

10626 crash report tool tip_OK

tACK, not relevant as it is outdated.

tACK
image

tACK

tACK

10557 Address Awaiting Payments

tACK, QR code with CAPITAL uppercase

  • Turbosync

    • Load wallet, check balance
    • Recover wallet, check balance
    • Reuse internal key, check balance

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Test vectors

tACK, shield icon is replaced by AS text in the column title
10253 AS column width fixed

tACK

nACK, to be fixed first: #10422

tACK Fixed: #8111 Fixed: #10144
nACK, #9952 - crash when sorting on labels: #11010
tACK - #9952 fixed

tACK
10287 USD amound pasted from clipboard only 2 decimals allowed

* Fixed USD parsing in the clipboard observer by   YohDeadfall in [Fixed USD parsing in the clipboard observer #10318](https://github.com/[/pull/10318](https://github.com/zkSNACKs/WalletWasabi/pull/10318))

tACK
10318 comma in amount pasted correctly

* [VDG] Fix Send - ´To´ field cuts off some letters at bottom by   soosr in [[VDG] Fix Send - ´To´ field cuts off some letters at bottom #10372](https://github.com/[/pull/10372](https://github.com/zkSNACKs/WalletWasabi/pull/10372))

tACK 10372_bottom of letters fully visible

* [VDG] Fix less option sends the same amount by   soosr in [[VDG] Fix less option sends the same amount #10332](https://github.com/zkSNACKs/WalletWasabi/pull/10332)

* [VDG] Fix Amount Suggestion not showing by   SuperJMN in [[VDG] Fix Amount Suggestion not showing #10624](https://github.com/zkSNACKs/WalletWasabi/pull/10624)

nACK still can repro: #10422 (comment)

* [VDG] CurrencyEntryBox - do not allow space by   soosr in [[VDG] CurrencyEntryBox - do not allow space #10875](https://github.com/zkSNACKs/WalletWasabi/pull/10875)

nACK, space is still accepted
10875 space still allowed in Currency entry box

tACK, 2 coins from reused address cannot be selected separately but together
10141_2.coins.from.reused.addredd.cannot.selected.separately.but.together.webm

tACK, see video in 10141

need another wallet to test is - will try later in the office

tACK
10417 copied amount suggested in flyout

tACK
10430_tx.shield.fixed.webm

DO LATER - webcam needed

tACK

tACK

DO the test on Linux with webcam

tACK

tACK

tACK

tACK

tACK

tACK

tACK
10460 crash report shown when Tor is not running

tACK
10599 crash report wording_OK

10626 crash report tool tip_OK

tACK, not relevant as it is outdated.

tACK image

tACK

tACK

10557 Address Awaiting Payments > > > > > * [Trivial] Fix QR Code in lowercase by SuperJMN in [[Trivial] Fix QR Code in lowercase #10816](https://github.com/%5B/pull/10816%5D(https://github.com//pull/10816))

tACK, QR code with CAPITAL uppercase

tACK

tACK

tACK

  • Turbosync

    • Load wallet, check balance
    • Recover wallet, check balance
    • Reuse internal key, check balance

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Test vectors

tACK, shield icon is replaced by AS text in the column title
10253 AS column width fixed

tACK

nACK, to be fixed first: #10422

tACK Fixed: #8111 Fixed: #10144
nACK, #9952 - crash when sorting on labels: #11010
tACK - #9952 fixed

tACK
10287 USD amound pasted from clipboard only 2 decimals allowed

* Fixed USD parsing in the clipboard observer by   YohDeadfall in [Fixed USD parsing in the clipboard observer #10318](https://github.com/[/pull/10318](https://github.com/zkSNACKs/WalletWasabi/pull/10318))

tACK
10318 comma in amount pasted correctly

* [VDG] Fix Send - ´To´ field cuts off some letters at bottom by   soosr in [[VDG] Fix Send - ´To´ field cuts off some letters at bottom #10372](https://github.com/[/pull/10372](https://github.com/zkSNACKs/WalletWasabi/pull/10372))

tACK 10372_bottom of letters fully visible

* [VDG] Fix less option sends the same amount by   soosr in [[VDG] Fix less option sends the same amount #10332](https://github.com/zkSNACKs/WalletWasabi/pull/10332)

* [VDG] Fix Amount Suggestion not showing by   SuperJMN in [[VDG] Fix Amount Suggestion not showing #10624](https://github.com/zkSNACKs/WalletWasabi/pull/10624)

nACK still can repro: #10422 (comment)

* [VDG] CurrencyEntryBox - do not allow space by   soosr in [[VDG] CurrencyEntryBox - do not allow space #10875](https://github.com/zkSNACKs/WalletWasabi/pull/10875)

nACK, space is still accepted
10875 space still allowed in Currency entry box

tACK, 2 coins from reused address cannot be selected separately but together
10141_2.coins.from.reused.addredd.cannot.selected.separately.but.together.webm

tACK, see video in 10141

need another wallet to test is - will try later in the office

tACK
10417 copied amount suggested in flyout

tACK
10430_tx.shield.fixed.webm

DO LATER - webcam needed

tACK

tACK

DO the test on Linux with webcam

tACK

tACK

tACK

tACK

tACK

tACK

tACK
10460 crash report shown when Tor is not running

tACK
10599 crash report wording_OK

10626 crash report tool tip_OK

tACK, not relevant as it is outdated.

tACK image

tACK

tACK
10557 Address Awaiting Payments

tACK

tACK

tACK

tACK

10512 user friendly error on PBST saving

@adamPetho please check it

  • Turbosync

    • Load wallet, check balance
    • Recover wallet, check balance
    • Reuse internal key, check balance

from walletwasabi.

adamPetho avatar adamPetho commented on September 24, 2024

@adamPetho please check it
Turbosync

Load wallet, check balance
Recover wallet, check balance
Reuse internal key, check balance
CoinJoin

Multiple coinjoins, observer number of coins, cost, anonscore gains
Feebump RBF fee bump payment transactions #10805

Pirvacy warnings #8622

Sorry @brizik but I only promised to go over the Hardware Wallet Kata tests yesterday. I can't go over all of this, I got other tasks to do.

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

@adamPetho please check it
Turbosync
Load wallet, check balance
Recover wallet, check balance
Reuse internal key, check balance
CoinJoin
Multiple coinjoins, observer number of coins, cost, anonscore gains
Feebump RBF fee bump payment transactions #10805
Pirvacy warnings #8622

Sorry @brizik but I only promised to go over the Hardware Wallet Kata tests yesterday. I can't go over all of this, I got other tasks to do.

@adamPetho
I meant the above ones of my comment as discussed hardware wallet related stuff.
so that one and Update HWI to 2.2.1 by jmacato in #10185

the other have been tested by me and @MarnixCroes this morning - all tACK.

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Turbosync

  • Load wallet, check balance - tACK
  • Recover wallet, check balance tACK
  • Reuse internal key, check balance - nACK ticket created by @MarnixCroes please mention here too

CoinJoin

Multiple coinjoins, observer number of coins, cost, anonscore gains
Feebump RBF fee bump payment transactions #10805

tACK

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Test vectors

tACK, shield icon is replaced by AS text in the column title
10253 AS column width fixed

tACK

nACK, to be fixed first: #10422

tACK Fixed: #8111 Fixed: #10144
nACK, #9952 - crash when sorting on labels: #11010
tACK - #9952 fixed

tACK
10287 USD amound pasted from clipboard only 2 decimals allowed

* Fixed USD parsing in the clipboard observer by   YohDeadfall in [Fixed USD parsing in the clipboard observer #10318](https://github.com/[/pull/10318](https://github.com/zkSNACKs/WalletWasabi/pull/10318))

tACK
10318 comma in amount pasted correctly

* [VDG] Fix Send - ´To´ field cuts off some letters at bottom by   soosr in [[VDG] Fix Send - ´To´ field cuts off some letters at bottom #10372](https://github.com/[/pull/10372](https://github.com/zkSNACKs/WalletWasabi/pull/10372))

tACK 10372_bottom of letters fully visible

* [VDG] Fix less option sends the same amount by   soosr in [[VDG] Fix less option sends the same amount #10332](https://github.com/zkSNACKs/WalletWasabi/pull/10332)

* [VDG] Fix Amount Suggestion not showing by   SuperJMN in [[VDG] Fix Amount Suggestion not showing #10624](https://github.com/zkSNACKs/WalletWasabi/pull/10624)

nACK still can repro: #10422 (comment)

* [VDG] CurrencyEntryBox - do not allow space by   soosr in [[VDG] CurrencyEntryBox - do not allow space #10875](https://github.com/zkSNACKs/WalletWasabi/pull/10875)

nACK, space is still accepted
10875 space still allowed in Currency entry box

tACK, 2 coins from reused address cannot be selected separately but together
10141_2.coins.from.reused.addredd.cannot.selected.separately.but.together.webm

tACK, see video in 10141

need another wallet to test is - will try later in the office

tACK
10417 copied amount suggested in flyout

tACK
10430_tx.shield.fixed.webm

DO LATER - webcam needed

tACK

tACK

DO the test on Linux with webcam

tACK

tACK

tACK

tACK

tACK

tACK

tACK
10460 crash report shown when Tor is not running

tACK
10599 crash report wording_OK

10626 crash report tool tip_OK

tACK, not relevant as it is outdated.

tACK image

tACK

tACK
10557 Address Awaiting Payments

tACK

tACK

tACK

tACK

10512 user friendly error on PBST saving > > > > > > > * Update HWI to 2.2.1 by jmacato in [Update HWI to 2.2.1 #10185](https://github.com/%5B/pull/10185%5D(https://github.com//pull/10185))

@adamPetho please check it

  • Turbosync

    • Load wallet, check balance
    • Recover wallet, check balance
    • Reuse internal key, check balance

tACK

8622_non-privat_semi-privat transaction warnings 8622_well protected transaction 8622_change avoidance_more_less 8622_full or better privacy

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

Change HdPubKey Labels after Transaction is sent by Szpoti in #10397

need another wallet to test is - will try later in the office
update: tACK (14/07/23)

from walletwasabi.

molnard avatar molnard commented on September 24, 2024

Awesome job @brizik and @MarnixCroes. @soosr can you take a look at the list and grab UI relateds?

@brizik In the office I set up a windows / linux dual boot machine. Do you come to the office nowadays?

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

@brizik In the office I set up a windows / linux dual boot machine. Do you come to the office nowadays?

I am on holiday this week and till next week Tuesday without internet connection.
Next Wednesday (07-26) I can go to the office - will you be there @molnard ?

from walletwasabi.

molnard avatar molnard commented on September 24, 2024

Next Wednesday (07-26) I can go to the office - will you be there

Nope, but the PC will be.

from walletwasabi.

molnard avatar molnard commented on September 24, 2024
  • DO the test on Linux with webcam

tACK.

from walletwasabi.

brizik avatar brizik commented on September 24, 2024

@MarnixCroes can you please check this one?
on the linus machine in the office it seemed not to be available after master check-out.

from walletwasabi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.