Code Monkey home page Code Monkey logo

Comments (6)

NicoSerranoP avatar NicoSerranoP commented on August 28, 2024 1

Hey @tvanepps! Almost finish here 🚀. Meanwhile, I add some comments to your observations

  1. The sequencer signs and sends a receipt after the participant uploads the contribution. We can use the sequencer address to confirm that the receipt was truly coming from the sequencer itself.

  2. We were thinking on showing the participants their 4 PoT pubkeys right away because these are like their unique fingerprints in the contribution. We should the identicons in the completed contribution modal and here. The color combination make them unique and it is a nice way to showing how every single contribution is unique in the list.

7.1. I voted on leaving the identicons outside and inside the modal.
7.2. We can put them in a 4x1 array

  1. Right now the sequencer is in development mode and it is accepting multiple contributions from the same participant

  2. The first audit report was related to the Small Powers of Tau implementation. We decided to swap that implementation with the sequencer crypto library (which was already audited in the second report). I feel we can leave only one Audit Report link to the Sigma Prime audit PDF

from trusted-setup-frontend.

PlasmaPower avatar PlasmaPower commented on August 28, 2024 1

One other UI consideration: If you're on e.g. the second page of contributions, and then you search for a particular address, it won't show up until you click the "1" at the bottom to jump back to the first page, which confused me at first.

from trusted-setup-frontend.

tvanepps avatar tvanepps commented on August 28, 2024

Generally, it's hard to know what this modal is telling users - should they be saving the info locally? we should consider adding some tooltips next to each header 🛈 that expands with info on hover, or just include all info next to the header by default.

    • the "x" appears differently when next to text vs a number
    • "Pot" is not useful. Should either say "Powers of Tau" or be omitted
    • Can we reproduce the identicons here next to their pubkey to show the link? if we do this, make sure the image is aligned with the left side of the header text above
    • "Sequence #" (or whatever it's changed to on the screen before) should also appear on this modal below "Contribution Details" - possibly with ←→ toggle so users can cycle through many contributions without having to exit and reenter this modal every time. the toggle arrows are a lower priority tho

image

from trusted-setup-frontend.

tvanepps avatar tvanepps commented on August 28, 2024
    • There should be a an action suggestion for each of the numbers/ arrow when i hover it should change to the hand cursor and be underlined/ drop shadowed
    • the footer is just a little too large. can we shrink it vertically to about the size of the red rectangle?
    • We will have 2 audit reports, maybe there needs to be separate links to the Implementation report and the sequencer audit? or just remove this link and send users to the documentation where they can find both
      image

from trusted-setup-frontend.

tvanepps avatar tvanepps commented on August 28, 2024

thanks for the clarifications/info. these generally make sense

  1. we probably need a guide for how users should verify contributions. see the namada trusted setup "Verify Contribution" button, instructions hosted on github. what would verification look like for our ceremony? eg. hosted on the interface itself vs. or another repo, what steps would the user need to complete, etc

  2. makes sense. we might need a tooltip for this to explain why unique identicons are important / what they signify

  3. makes sense, carl also explained why this is the case. we should definitely start with a clean slate when the time comes

  4. sounds good, we will need to upload the completed report to the kzg repo when it's produced and point to that one

from trusted-setup-frontend.

glamperd avatar glamperd commented on August 28, 2024

image

The Signed by field is confusing. It shows the identity of the contributor, but it's under the title of 'Sequencer Acknowledgement' I feel it should show the sequencer's address, as proof that the real sequencer signed the receipt.

The contributor identity could also be shown on the page, but in a different place so it's clear it belongs to the contributor, not the sequencer.

from trusted-setup-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.