Comments (4)
jmackie
commented on July 23, 2024
1
Don't mind me, just passing through, but I noticed:
bad_bit: (node.start_byte(), node.end_byte()).into(), // ISSUE HERE
Should that not be...
bad_bit: (node.start_byte(), node.end_byte() - node.start_byte()).into(),
As the convert impl says (start, len)?
from miette.
zkat
commented on July 23, 2024
Oh this is a pretty good bug. So what you're trying to do is point at the newline whitespace itself?
from miette.
zkat
commented on July 23, 2024
oh yeah. That'd do it. Spans in miette are (offset, len), not (start, end), for some good reasons :)
from miette.
bnjjj
commented on July 23, 2024
Ok it's better now ! Thanks a lot ! My prediction about the bug with whitespaces was wrong. Sorry for this. I made a pr to have less confusion next time
from miette.
Related Issues (20)
- Allow the inner source type of a `NamedSource` to be borrowed directly HOT 1
- More controlability for the `label` HOT 5
- `Severity` should implement `Ord`
- Allow spans in `help` to provide structured suggestions HOT 3
- Backtrace and Spantrace support HOT 5
- Update miette-derive syn dependency to syn 2 HOT 2
- Still print the name of the SourceCode even if all the labels are invalid
- How to manually collect and print errors HOT 2
- Add source slices HOT 1
- Expose access to line and column info from SourceSpan HOT 3
- Add struct for dynamic creation of diagnostics HOT 2
- Use serde HOT 4
- Constify `SourceOffset` and `SourceSpan` HOT 1
- Add `FixIt` support
- Fix overlapping labels HOT 1
- Make "Error: " prefix in error messages configurable/optional HOT 5
- Do I need to fill the source content of NamedSource by myself? HOT 2
- `#[source]` does not work on `Box<dyn Error + Send + Sync>`
- Unexpected behaviour on empty span HOT 2
- Unable to work with &Result<T, E>
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miette.