How to set prompt on authorize request about oidc HOT 6 CLOSED

Hey @shnplr

I see the problem. The AuthURLHandler currently does not allow to do so.
It's only possible in the AuthURL function:

http.Redirect(w, r, rp.AuthURL(state, provider, rp.WithPrompt(oidc.PromptSelectAccount)), http.StatusFound)

I'll create a PR to change it and for the CodeExchange / CodeExchangeHandler.

from oidc.

@livio-a can you glance into this?

from oidc.

@livio-a
If we expose opts ...AuthURLOpt in AuthURLHandler(), there will be a hypothetical case where a double code challenge can be set. 1 time by the caller using WithCodeChallenge() directly and 1 time by the conditional below:

There is no way of knowing if it was already set in opts, as the AuthURLOpt type is a function, which cannot be compared to be equal in Go. Perhaps calling the option and comparing outputs or some other de-duplication logic when building the redirect URL, but that would be a dirty solution.

As WithPrompt() and WithCodeChallenge() are the only 2 AuthURLOpts, I would propose to only expose the ability of setting additional prompts:

func AuthURLHandler(stateFn func() string, rp RelyingParty, prompts ...string) http.HandlerFunc {
...
    if len(prompts) > 0 {
        opts = append(opts, WithPrompt(prompts...))
    }
...
}

... and for the CodeExchange / CodeExchangeHandler.

Likewise, for CodeExchangeHandler() there are only 2 CodeExchangeOpts and both of them are set in conditionals. IMO we shouldn't change anything here:

from oidc.

Oops. I just now read #265, which would add more options. I will give it some more thought.

from oidc.

I think I found a suitable solution. Perhaps we should continue the conversation at PR #273. Have a good weekend.

from oidc.

🎉 This issue has been resolved in version 1.13.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from oidc.