proposal: improve logging about oidc HOT 4 CLOSED

We can already look into adding context where required, while the exact way of implementing logging is being investigated. #309 is meant to split the change of context and logging.

from oidc.

The Go ecosystem is full of different loggers. Some better than others. Developers often have different opinions on this subject. I feel that it is not the place of a library to make a fixed decision on a log implementation.

Yes, xop looks like a good choice for the above reasons, but our zitadel product already build on logrus for example. There might be reasons to change that, but that could take some time after any decision is taken. Meanwhile, we (urgently) need to improve the situation around logging.

Inspired by jackc/pgx, which offers a general logging interface and adapters towards the major logging libraries that are available, I've looked around to the possibility if we can provide something similar.

https://github.com/go-logr/logr seems to be a very valid option to achieve a similar solution:

• Defines an interface which can be used inside the oidc framework;
• Can be put inside a context.Context and safely retrieved;
• Implementations for most major loggers;
• It is a mature package, used by many.
• It is reasonable maintained. Last commit 3-dec-2022, and some PRs that are WIP by the developers.

By using logr we give power to the package users to make their own decisions on a logger. Also, I shouldn't be much work to create an adapter for xop.

from oidc.

CC @zitadel/engineers, @fforootd

from oidc.

logr proposal was accepted during internal meeting. This issue is replaced by user story #379.

from oidc.