Code Monkey home page Code Monkey logo

Comments (3)

livio-a avatar livio-a commented on May 29, 2024 2

Hey @zarkoc

First of all: Thanks for the issue.
There seems to be an error in the readme. As you mentioned, we use the oauth2 module which does not support the implicit flow.

Is there any reason why you need to use the implicit flow?

Because IMHO there is no need to support it. The implicit grant was designed for OAuth public clients, which were not able to store a secret. So as a confidential web application there's no need to use it. For various security reasons OAuth2 best current practice proposes to use PKCE instead and OAuth 2.1 will drop it from the specs.

from oidc.

zarkoc avatar zarkoc commented on May 29, 2024

As far as I can see we can't modify the responce_type from code?
The relyingParty struct is using oauthConfig *oauth2.Config, which comes from the oauth2 module, and the code responce_type is hardcoded there.
https://cs.opensource.google/go/x/oauth2/+/6b3c2da3:oauth2.go;l=154

But the readme.md in the Features section explicitly mentions that is supports the ImplicitFlow for RP, so I guess Im missing something?

Thanks,
Zarko

from oidc.

fforootd avatar fforootd commented on May 29, 2024

Hi there let me check this tomorrow 😎

cc @livio-a @fgerschwiler

from oidc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.