Comments (4)
Shouldn't this be done based on the call site, and not the function type?
from zls.
This should be based on a combination of both, the current implementation will skip the first agument when the first argument is of the same type as the container the function is defined in (or a pointer to it).
Ideally we should only check this when we complete the function in a field access expression and the left hand side expression is not the type itself but an instance of the type.
from zls.
Ideally we should only check this when we complete the function in a field access expression and the left hand side expression is not the type itself but an instance of the type.
Yeah, that's what I was saying. (checking that it's an instance)
from zls.
This is an issue in pretty much all contexts atm, we complete the same for intances of a type as well as the type itself, I will address this soon ™️
from zls.
Related Issues (20)
- Bulid error with latest zig version
- namespace with same name as primitive breaks hover events + completion HOT 1
- the bug issue template should put expected behavior after actual HOT 1
- show size/alignment/padding in tooltip for type annotations HOT 1
- Snippets should be configurable HOT 2
- Intellisense for conditionally added modules HOT 3
- Zls shows incorrect types with nested ArrayLists HOT 1
- Local ZLS config per project HOT 5
- provide completions for creating `std_options` HOT 5
- writeFile2 options give completions for `Dir` instead of options struct HOT 1
- autofix messes with comment at line end
- `textDocument/rename` does not consider anonymous struct literals in return expressions
- Auto-completion and type function and variable not working with a pointer slice indexing HOT 2
- cInclude no longer showing added libraries. HOT 2
- Renaming a local variable should be instant.
- Autocomplete union(enum) variant
- C header path option HOT 2
- zls crashes in `instanceTypeVal`
- Lsp references (textDocument/references) took a long time in nvim lsp, even for simple file HOT 2
- Lsp 'textDocument/signatureHelp' doesn't work for the rightmost parenthesis of a function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zls.