Private declarations should show up in completions when not from imported types about zls HOT 7 CLOSED

I actually had this exact same thought 1 hour ago and fixed this in one of the recent commits, which should be pushed! If you pull the most recent version of zls, you should not get private decls showing up in import statements!

from zls.

Ah, I didn't notice. This is coming together so quickly. Works correctly after updating to master.

from zls.

This should now be fixed thanks to @alexnask's PR! Can you tell us if this is the intended behavior you expect? Thanks! 🎉

from zls.

Now the issue is that private declarations in the same file are not completed.

const foo  = struct {
    var a = 1;
    pub var b = 2;
};
test "" {
    foo. // only b shows up
}

Also visib_token can only ever be pub so we can just check visib_token != null.

from zls.

Isn't this the correct behavior?

from zls.

Isn't this the correct behavior?

No, pub is only needed when accessing declarations in different files.

from zls.

Works as expected now.

from zls.