Code Monkey home page Code Monkey logo

Comments (5)

gspr avatar gspr commented on June 30, 2024 1

The file tests/ota/files/ikea/mgm210l-light-cws-cv-rgbw_release_prod_v268572245_3ae78af7-14fd-44df-bca2-6d366f2e9d02.ota is not downloaded from IKEAs feed its sniffed with wireshark then Dirigera hub have updating one device and rebuild as one plane Silabs OTA file that is signed by IKEA. From the Principe i agree with you nd best is letting Z2M having the dirty OTA files not not in this organisations GIT for not getting problems in the future. But we have spreading very much dumped firmware and bootloaders from IKEA devices so users can recovering there device then IKEA have making bad firmware's.

How the file was obtained (download, sniffing, or otherwise) is irrelevant here, I'm afraid. At best, ZigPy currently implicitly indicates that said files are under a license that they are not. At worst, ZigPy is actively infringing the rights of the copyright holders for those files.

from zigpy.

MattWestb avatar MattWestb commented on June 30, 2024

The file tests/ota/files/ikea/mgm210l-light-cws-cv-rgbw_release_prod_v268572245_3ae78af7-14fd-44df-bca2-6d366f2e9d02.ota is not downloaded from IKEAs feed its sniffed with wireshark then Dirigera hub have updating one device and rebuild as one plane Silabs OTA file that is signed by IKEA.
From the Principe i agree with you nd best is letting Z2M having the dirty OTA files not not in this organisations GIT for not getting problems in the future.
But we have spreading very much dumped firmware and bootloaders from IKEA devices so users can recovering there device then IKEA have making bad firmware's.

from zigpy.

pipiche38 avatar pipiche38 commented on June 30, 2024

Even in you hack via a Man in the Middle, the firmware is still the property of the manufactuer, doesn't really matter how you get it.
Without the rights from the manufacturer I don't think you are allow to put into a any License mecanism

from zigpy.

puddly avatar puddly commented on June 30, 2024

Are unit tests considered code covered by the GPL? The final PyPI package does not include any test files.

from zigpy.

gspr avatar gspr commented on June 30, 2024

Are unit tests considered code covered by the GPL? The final PyPI package does not include any test files.

IANAL, but I don't think the GPL (or any other popular license) makes the distinction.

The way I see the matter, there's two separate problems:

  1. The copyright holder for the OTA update files do not allow you to redistribute them. Yet you do. This is a problem between the ZigPy authors and those upstream copyright holders. (Incidentally, this probably also puts you in violation of GitHub's terms of service, in which case there's also a problem between you and GitHub.)
  2. Downstream users and/or redistributors of ZigPy approach the ZigPy git repository and think "cool – I wanna use this, let's look at which license the authors have put the code under". They then see only the single notice of ZigPy being GPL3+. With no other notices or specifications anywhere in the repository, they are led to believe (reasonably, in my mind) that every file in the repository is GPL3+. That is clearly not true after those OTA update files were added. This is a problem between the ZigPy authors and the ZigPy users (and probably also between the ZigPy authors and the OTA copyright holders, as you are misleading third parties about their licenses).

Either way, a serious project needs to take issues like these seriously. Ideally, the license for each file in the repository should be clearly stated. But the easiest fix would be to simply drop the files for which you are not absolutely certain of the license (which I assume includes the OTA update files).

from zigpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.