Code Monkey home page Code Monkey logo

Comments (2)

Zhuinden avatar Zhuinden commented on May 24, 2024

If you mean simple-stack-example-fragments, then every "concrete" (in quotation marks) key in the sample is generated by AutoValue, which means equals and hashCode are generated by AutoValue based on the abstract field getters.

And same seems to be the case for the simple-stack-flow-masterdetail-fragments.

I think if there's a sample where this could be an issue, it's the newly added mortar-sample because that only checks against instanceof instead of true object equality. Maybe I should convert all samples to use AutoValue because nobody (hopefully) really writes this parcelable equals hashcode toString by hand anymore.


In the fragment sample, the trick is that getFragmentTag() seems to be return toString(); so it's based on the object's properties. So it should work either way.

from simple-stack.

Zhuinden avatar Zhuinden commented on May 24, 2024

I've changed all samples to use auto-parcel.

AutoValue generates equals/hashcode/toString in all cases.

To remove classes from being used in equals/hashCode, you can use https://github.com/REggar/auto-value-ignore-hash-equals library.

I think that should make behavior consistent. If you see any oddity though, please report.

from simple-stack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.