Falling animation repeats about brokenview HOT 5 OPEN

@zhanyongsheng any idea what could be the reason for this?

from brokenview.

I'm seeing the same issue on Android 8. Doesn't happen on Android 6.

from brokenview.

The problem seems to be in BrokenAnimator here:

        if (fraction > 0.8 && bPressed) {
            canReverse = false;
            setRepeatCount(1);
        }

Not exactly sure what the problem is, but I think this is where the repeated animation is set up.

from brokenview.

Here's a hack that gets around the repeating animation. It's probably not the best solution, but it works so I'll use it for now. In BrokenAnimator.draw change:

public boolean draw(Canvas canvas) {

    if (!isStarted()) {
        return false;
    }

    float fraction = getAnimatedFraction();

To this:

private HashMap<Integer,Float> stageToPercentageMap = new HashMap<>();

public boolean draw(Canvas canvas) {

    if (!isStarted()) {
        return false;
    }

    float whatAndroidThinksThePercentageIs = getAnimatedFraction();

    if (stageToPercentageMap.get(getStage()) == null ||
            stageToPercentageMap.get(getStage()) < whatAndroidThinksThePercentageIs)
    {
        stageToPercentageMap.put(getStage(),whatAndroidThinksThePercentageIs);
    }

    float fraction = stageToPercentageMap.get(getStage());

Android 8 seems to be running the animation too quickly and we end up getting a repeated FALLING state. Basically, this just makes sure that the percentage completion for each state is always going UP, not down.

from brokenview.

@metaphyze thx. How about a Pull Request, so the owner of this project will hopefully review and merge it.

from brokenview.