Some enhancements about pugixml HOT 3 CLOSED

Actually, as the attributes are a map with unique keys, the operator[] could work like the std::map operator[], so that it will add a new attribute if it does not exist. Makes it simple to add and update attributes, and to look up attributes that are mandatory. Optional attributes should be accessed with the usual attribute(name) method:

xml_attribute operator[](string_arg name) {
    xml_attribute att = attribute(name);
    return att ? att : append_attribute(name);
}

Example:

node["radius"] = 0.5; // add attribute
node["radius"] = 1.0; // update it.
double r = node["radius"].as_double(); // look up mandatory attribute

from pugixml.

This was the 1st thing I've added once cloned the library.

from pugixml.

FWIW there's a lot of different opinions on the syntax and semantics of the operators (should [] automatically add an attribute? should it only do it if the attribute is a non-const value?).

A straightforward answer is to only provide read-only operators for attributes, but that just saves a tiny bit of typing over explicit .attribute calls.

Overall it doesn't seem like it's an obviously good idea. It saves typing, which is great, but it introduces additional syntax that duplicates existing one - see #255 for a different take. I'm going to close this since I think it's best that pugixml core interface remains unambiguous and clear.

from pugixml.