Code Monkey home page Code Monkey logo

Comments (4)

omaxel avatar omaxel commented on June 7, 2024 1

The roving tabindex technique requires JavaScript since the component needs to listen for keypress events (e.g. arrow up).

After reviewing the behavior of tabs, I believe the real problem relies on labels' keyboard interactions (pressing enter or space) not being reflected to the linked radio button. As proof of this, I made the labels focusable by adding tabindex=0. Pressing the enter or the space key after focusing one of the labels, doesn't affect the state of the related radio button.

In order to solve the problem, I think we should remove display: none from the radio buttons allowing focus on them. We still need to hide them from the UI by using other techniques.

With this approach:

  • it's possible to navigate between tabs using left and right arrow keys; the same interaction provided by radio buttons;
  • clicking a label will check and focus the related radio button;
  • labels can also display the outline (or any other focus indicator) based o the focused radio button.

You can find a preview in the image below:
GRcS8sec1I

Also, note how the focus ring disappears when I click outside of the element, like on any native element.

What do you think?

from cssui.

zetareticoli avatar zetareticoli commented on June 7, 2024 1

You did it! Great work.

At this point, you could self-assign this issue and go ahead in the dedicated branch.

Thank you!

from cssui.

zetareticoli avatar zetareticoli commented on June 7, 2024

We should consider using the "roving tabindex" technique.

https://web.dev/control-focus-with-tabindex/#create-accessible-components-with-%22roving-tabindex%22

What do you think?

from cssui.

zetareticoli avatar zetareticoli commented on June 7, 2024

Fixed in 9de70ac

from cssui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.