zeropush / zero_push Goto Github PK

https://github.com/ZeroPush/zero_push/blob/master/lib/zero_push/client.rb

Can you make this parameterized?
URL = 'https://api.zeropush.com'.freeze
It helps customers who migrated to another services

ZeroPush gives you a pair of tokens for each app. It would be nice to have an easy way to configure an switch to which app you want to send requests.

https://zeropush.readme.io/v1.5/docs/broadcast
says there is an optional channel with a broadcast. but the client.rb file looks like it does not supply a channel. I could monkey-patch my code or take a stab at making a PR for this

moving issue from: https://github.com/SymmetricInfinity/zero_push/issues/7

Per the ZeroPush / PushWoosh migration documentation it seems that there is parity between the two providers' APIs:

And of course, if you use Zeropush API in your backend - point it from https://api.zeropush.com to https://zeropush.pushwoosh.com too!

If this is the case it seems that this Ruby Client library could be made compatible with PushWoosh by updating the following line of code: https://github.com/ZeroPush/zero_push/blob/master/lib/zero_push/client.rb#l6

If my assumptions are correct, would it be possible to create a fork of this library with the suggested change? I'm happy to create the fork.

Thank you for your help in advance and congrats on the acquisition!