t/errors.t fails with German locale about perlzmq HOT 8 CLOSED

There's something wrong on that test box, the locale specific string is already being checked, not the literal "Invalid argument":
https://metacpan.org/source/CALID/ZMQ-FFI-0.17/t/errors.t#L21

I'm also able to install locally under the german locale without issue...
http://pastebin.com/Bxwk5g5R

from perlzmq.

The mentioned fail report is from perl 5.21.8. Bleadperl behaves differently than earlier perls:

$ env LC_ALL=de_DE.UTF_8 perl5.21.9 -E '$!=1; say "$!"'
Operation not permitted
$ env LC_ALL=de_DE.UTF_8 perl5.20.2 -E '$!=1; say "$!"'
Die Operation ist nicht erlaubt

from perlzmq.

And it is the locale, here's a pass/fail pair from the perl version on the same box, just with different LC_ALL settings (C vs. de_DE.UTF-8):

• http://www.cpantesters.org/cpan/report/af937d90-b9d2-11e4-8430-2395e0bfc7aa
• http://www.cpantesters.org/cpan/report/914bfcea-b9d2-11e4-b3ef-c494e0bfc7aa

from perlzmq.

hmm, this looks like a bug in the latest Perl... it's not honoring the locale when string-ifying $!. You should report this as a bug in Perl itself.

from perlzmq.

To expand a bit, ZMQ::FFI gets the error string by using zmq_strerror. This returns the properly localized error string. Then in the test, I get the expected localized error string by simply setting $! to EINVAL and stringifying it. In previous Perl versions this worked, but as your comment above demonstrates this is broken in the latest Perl... it's always producing the english version of $!.

from perlzmq.

No, this is an intentional change in perl 5.21.x. To get the localized stringified $!, you have to enclose it in use locale now. From perl5211delta.pod:

"$!" text is now in English outside "use locale" scope
Previously, the text, unlike almost everything else, always came out
based on the current underlying locale of the program. (Also affected on
some systems is ""$^E"".) For programs that are unprepared to handle
locale, this can cause garbage text to be displayed. It's better to
display text that is translatable via some tool than garbage text which
is much harder to figure out.

from perlzmq.

@eserte I believe this should be resolved now. Let me know if you have any further issues.

from perlzmq.

I think the change looks good. Will know for sure when you're releasing a new version to cpan and cpantesters.

from perlzmq.