Defining inline __inline causes MSVC 2012 error about czmq HOT 11 CLOSED

Need to double check this doesn't break compiles on older versions of MSVC...

from czmq.

It breaks MSVC builds when compiling as C, not C++.

error C2054: expected '(' to follow 'inline'

from czmq.

Can you build as C anyhow? I thought we needed C++ language features.
On Aug 2, 2013 12:28 PM, "Mike Williams" [email protected] wrote:

It breaks MSVC builds when compiling as C, not C++.

error C2054: expected '(' to follow 'inline'

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/212#issuecomment-21997876
.

from czmq.

We build czmq as C++ but include and link into a C application.

from czmq.

@mrdubya where does the error occur? In your own code?

from czmq.

No, it fails in czmq_prelude.h. All I did was delete the definition of inline as per the commit above. This results in the following in our C code that includes czmq.h:

f:\zeromq\czmq\include\czmq_prelude.h(432) : error C2054: expected '(' to follow 'inline'
f:\zeromq\czmq\include\czmq_prelude.h(438) : error C2085: 'safe_malloc' : not in formal parameter list
f:\zeromq\czmq\include\czmq_prelude.h(438) : error C2143: syntax error : missing ';' before '{'
NMAKE : fatal error U1077: '"G:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\BIN\cl.EXE"' : return code '0x2'
Stop.

Not sure why we don't see a problem when building czmq as C++. It looks like xkeycheck.h is only included from standard C++ headers so wont be seen when compiling C++ code that does not include a C++ standard header. You may just need a #if !defined(__cplusplus) around the definition of inline.

from czmq.

OK, I've made a further pull request - if you remove the 'inline' in that
definition, it should all work.

On Fri, Aug 2, 2013 at 6:00 PM, Mike Williams [email protected]:

No, it fails in czmq_prelude.h. All I did was delete the definition of
inline as per the commit above. This results in the following in our C code
that includes czmq.h:

f:\zeromq\czmq\include\czmq_prelude.h(432) : error C2054: expected '(' to
follow 'inline'
f:\zeromq\czmq\include\czmq_prelude.h(438) : error C2085: 'safe_malloc' :
not in formal parameter list
f:\zeromq\czmq\include\czmq_prelude.h(438) : error C2143: syntax error :
missing ';' before '{'
NMAKE : fatal error U1077: '"G:\Program Files (x86)\Microsoft Visual
Studio 11.0\VC\BIN\cl.EXE"' : return code '0x2'
Stop.

Not sure why we don't see a problem when building czmq as C++. It looks
like xkeycheck.h is only included from standard C++ headers so wont be seen
when compiling C++ code that does not include a C++ standard header. You
may just need a #if !defined(__cplusplus) around the definition of inline.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/212#issuecomment-22015377
.

from czmq.

Sorry, nope, that breaks the build for other reasons... :-/ Let me try
something else

On Fri, Aug 2, 2013 at 10:31 PM, Pieter Hintjens [email protected] wrote:

OK, I've made a further pull request - if you remove the 'inline' in that
definition, it should all work.

On Fri, Aug 2, 2013 at 6:00 PM, Mike Williams [email protected]:

No, it fails in czmq_prelude.h. All I did was delete the definition of
inline as per the commit above. This results in the following in our C code
that includes czmq.h:

f:\zeromq\czmq\include\czmq_prelude.h(432) : error C2054: expected '(' to
follow 'inline'
f:\zeromq\czmq\include\czmq_prelude.h(438) : error C2085: 'safe_malloc' :
not in formal parameter list
f:\zeromq\czmq\include\czmq_prelude.h(438) : error C2143: syntax error :
missing ';' before '{'
NMAKE : fatal error U1077: '"G:\Program Files (x86)\Microsoft Visual
Studio 11.0\VC\BIN\cl.EXE"' : return code '0x2'
Stop.

Not sure why we don't see a problem when building czmq as C++. It looks
like xkeycheck.h is only included from standard C++ headers so wont be seen
when compiling C++ code that does not include a C++ standard header. You
may just need a #if !defined(__cplusplus) around the definition of inline.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/212#issuecomment-22015377
.

from czmq.

OK, tried something else. Since I don't have MSVC to test on, I can't be
100% this works.

On Fri, Aug 2, 2013 at 10:38 PM, Pieter Hintjens [email protected] wrote:

Sorry, nope, that breaks the build for other reasons... :-/ Let me try
something else

On Fri, Aug 2, 2013 at 10:31 PM, Pieter Hintjens [email protected] wrote:

OK, I've made a further pull request - if you remove the 'inline' in that
definition, it should all work.

On Fri, Aug 2, 2013 at 6:00 PM, Mike Williams [email protected]:

No, it fails in czmq_prelude.h. All I did was delete the definition of
inline as per the commit above. This results in the following in our C code
that includes czmq.h:

f:\zeromq\czmq\include\czmq_prelude.h(432) : error C2054: expected '('
to follow 'inline'
f:\zeromq\czmq\include\czmq_prelude.h(438) : error C2085: 'safe_malloc'
: not in formal parameter list
f:\zeromq\czmq\include\czmq_prelude.h(438) : error C2143: syntax error :
missing ';' before '{'
NMAKE : fatal error U1077: '"G:\Program Files (x86)\Microsoft Visual
Studio 11.0\VC\BIN\cl.EXE"' : return code '0x2'
Stop.

Not sure why we don't see a problem when building czmq as C++. It looks
like xkeycheck.h is only included from standard C++ headers so wont be seen
when compiling C++ code that does not include a C++ standard header. You
may just need a #if !defined(__cplusplus) around the definition of inline.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/212#issuecomment-22015377
.

from czmq.

Works for me. czmq builds and my C builds are ok as well. And the check for inline already being defined is a nice touch for existing C apps that have done something similar for setting up a C99-alike environment.

from czmq.

Nice, thanks.

On Mon, Aug 5, 2013 at 11:26 AM, Mike Williams [email protected]:

Works for me. czmq builds and my C builds are ok as well. And the check
for inline already being defined is a nice touch for existing C apps that
have done something similar for setting up a C99-alike environment.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/212#issuecomment-22095348
.

from czmq.