Need to know in validator which event fired it about neoform HOT 6 CLOSED

@tirli done, [email protected]

from neoform.

I got the idea and the issue... I'm not sure which types we should pass in validator, it feels more like NeoForm internals you shouldn't rely on. I'm thinking more about propagating a form-wide prop like isSubmitting so you can choose which validator to use from outside.

const userNameValidator = (isSubmitting) => (value) => {
  return isSubmitting ?
         Promise.resolve('valid on submit') :
         Promise.resolve('valid on some other event')
}

// ...

<MyInput name="user.name" validator={userNameValidator(isSubmitting)} />

I'm not quite sure that something like this will work because we need to render first with isSubmitting, receive updated validator function and only after that validate the form, but I like the idea of making it more abstract and flexible in any way. What do you think? Or do you have an idea on how to pass those validator "types"?

from neoform.

Btw, we can internally call validator with field or form "types", right from formValidation:

validateField(name) {
  // ...
  validator(value, 'field')
  // ...
}

validateForm(successHandler, errorHandler) {
  // ...
  return validator(value, 'form')
  // ...
}

It's more about source or reason of validation than a type, but it's still the easiest fix.

from neoform.

It seems like the first one wouldn't work because there is still only one validator. So closure wouldn't help.

The second approach is better, but it wouldn't work if I need to detect if it blur or change or some other event.

I think that we can add an argument to validate method. Most of the cases it's used like
<input onChange={validate} /> so it will be getting an event. So we can use event.type inside or if it was called directly by user he should provide a { type: 'myCustomAction'} of just nothing. What is more, the same thing we can make with submitting. Add it as a custom type.

from neoform.

Sorry I still don't have much time to work on NeoForm :( Your PR is merged, but I'm going to release it together with #11

from neoform.

@deepsweet If it possible, can you please release it before? So it wouldn't be blocking me and you won't need to fix #11 as soon as possible and can fix it when you'll have time

from neoform.