Allow import of optional projects from manifest file about west HOT 7 OPEN

I can add group-filter: [+optional] to the manifest file, but this can lead to more projects being updated than necessary.

How? You have an allow list

from west.

How? You have an allow list

In this particular case, yes. But I think it would be nice to have using import: true too.

from west.

@pdgendt Have you given any thought to whether this should be higher or lower precedence than the manifest.project-filter configuration option? I guess the configuration option should have higher precedence, since it's the only convenient way to do things on a per-workspace basis. Agree?

from west.

Another question I would like you to answer is: how should this work across import: statements?

This is subtle and tricky. Having group-filter propagate across imports was a disaster at first and we had to reverse course and tell people not to use group-filter with import in west 0.9, essentially deprecating that release entirely: https://docs.zephyrproject.org/latest/develop/west/release-notes.html#v0-9-0

Be sure to consider what happens if you import two different projects, with conflicting project-filter values.

I seem to recall that complexities of this type are why we did not implement this in the first place.

from west.

we had to reverse course and tell people not to use group-filter with import in west 0.9, essentially deprecating that release entirely

Longer story in:

• #481
• #482

This is subtle and tricky.

I tried to gather all relevant discussions in Partial imports Incomplete or changing imports are much more complicated than you think (+ click "closed")

cc:

• zephyrproject-rtos/zephyr#61505

from west.

@mbolivar-ampere thanks for voicing your concerns, I didn't know the complexity was this deep, so it might not be something we want to bother with adding.

It's because of a recent change that the optional group is left out by default, and the "installation instructions" of our projects changed because of that. It would've been nice to update the west.yml file only (we can, but with group-filter) instead of modifying readme files, CI jobs, ...

It also looks quite odd that a project that is added explicitly to the import whitelist, is still ignored.

from west.

What I did was add the "optional" to the group filter in my west.yml, and then use the allowlist to only pull in the specific modules I wanted, both from the main manifest and the optional manifest. Am I misunderstanding what you're trying to do @pdgendt ?

from west.