Code Monkey home page Code Monkey logo

Comments (13)

zenire avatar zenire commented on June 29, 2024

Couldn't you visit the website over https:// with the valid Let's Encrypt certificate when ssl=OFF ?

from da-letsencrypt.

Bramzor avatar Bramzor commented on June 29, 2024

Apparently it does work now when using https://, although there is still an issue with the location as the webpage does only display: "Nginx is functioning normally". So the VirtualHost configuration was not updated somehow.

from da-letsencrypt.

Bramzor avatar Bramzor commented on June 29, 2024

Activating ssl via http://IP:2222/CMD_ADDITIONAL_DOMAINS?action=view&domain=somedomein.ext helped. Could we add this to the flow somewhere or activating it by default when creating a ssl certificate for a domain?

from da-letsencrypt.

Wouter0100 avatar Wouter0100 commented on June 29, 2024

Hmm, good point. I'll think we've to disable the Let's Encrypt-plugin page when SSL isn't enabled for this domain. I don't see any reason to enable this automatically.

from da-letsencrypt.

Bramzor avatar Bramzor commented on June 29, 2024

For example yes.
Can't we use this inside the plugin?
|_if USERSSL="ON"|
Show scipt
|_else|
Show message to activate SSL first including the link
|*endif|

from da-letsencrypt.

zenire avatar zenire commented on June 29, 2024

I want to offer my clients a free Let's Encrypt certificate, but not the option to install other certificates. For me it would be nice if the plugin works without the DirectAdmin SSL being enabled for the user.

from da-letsencrypt.

Bramzor avatar Bramzor commented on June 29, 2024

Are you using custombuild v2 with nginx_apache ?
Because if SSL is not enabled, the nginx config (and also the apache config if I recall correctly) won't have the listeners configured on port 443.

from da-letsencrypt.

zenire avatar zenire commented on June 29, 2024

Yes.

Apache and Nginx will always listen on 443.

The error you will get with SSL disabled is:
Successfully received certificate from Let's Encrypt.
Error while executing first API request: You are not allowed to modify your
ssl settings

from da-letsencrypt.

Bramzor avatar Bramzor commented on June 29, 2024

Apache and Nginx are both listening to 443 but in the vhost file, there wasn't any configuration with a vhost for port 443. (Although it was the first SSL certificate on the server and on that specific IP)
Also I did not see the above error.
If SSL is not set to ON, there was no vhost configuration created or SSL and therefore, SSL did not work. Only after enabling/activating SSL via the old method, it worked.

from da-letsencrypt.

Wouter0100 avatar Wouter0100 commented on June 29, 2024

@Petertjuh360, that's not possible. SSL must be enabled and we can't change this requirement.

from da-letsencrypt.

zenire avatar zenire commented on June 29, 2024

I just experienced it and it isn't possible indeed.

What shall we do when an user does not have SSL access and he uses the plugin? The suggestion of @Bramzor looks good.

from da-letsencrypt.

Wouter0100 avatar Wouter0100 commented on June 29, 2024

Yeah, I already had something like that in mind. Unfortunately, his example isn't in PHP, but I'll implement this when I have the change :). Shouldn't be that hard, we could use the Logger for this.

from da-letsencrypt.

Bramzor avatar Bramzor commented on June 29, 2024

Which of the 2 will you implement?
Hiding the functionality when SSL isn't activated showing a link to activate SSL seems the best option. I'm also going to place a warning on the normal SSL certificate page pointing to the plugin to avoid confusion after enabling SSL functionality.

from da-letsencrypt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.