Factory backed pipelines cannot be composed/nested in other pipelines about zend-expressive HOT 3 CLOSED

Okay, I've been able to create a small project that has the dependencies necessary to run the test, and verified the behavior.

For those who have clicked through to the gist, it's the second test that fails. Essentially, the first middleware executes, and then it descends into the nested pipeline, which executes correctly - but once complete, it does not return to the parent middleware.

This is quite odd, as this is almost exactly the sort of behavior that occurs when you run routed pipelines, which definitely work!

I need to investigate more here to determine if the issue is with how the MiddlewareFactory is creating the nested pipeline, or if there's an issue within MiddlewarePipe that needs to be resolved. I'll post more when I've had more time to investigate.

from zend-expressive.

I figured out the problem: https://github.com/zendframework/zend-expressive/blob/master/src/MiddlewareContainer.php#L66-L68

What happens here is that MiddlewarePipe is also a RequestHandlerInterface, which means that pipelines then get cast to RequestHandlerMiddleware, which then calls handle() on the pipeline, instead of process().

Locally, I changed that to:

if ($middleware instanceof RequestHandlerInterface
    && ! $middleware instanceof MiddlewareInterface
) {
    $middleware = new RequestHandlerMiddleware($middleware);
}

This allows both of your tests to pass, which is good. Next step is to figure out a succinct way to reproduce the issue as a unit test, at which point I can write a patch.

from zend-expressive.

That's great! Thanks ever so much - That test I wrote is a country mile from succinct I'll agree 😂

from zend-expressive.