Improve naming of `itemsPerRow` about spots HOT 12 CLOSED

How about preferredNumberOfRows ?

from spots.

@onmyway133 yeah I kinda like that, but I wouldn't add preferred as a prefix. If you set that, it will arrange the items based on the items height which would give you a "column" height of 2 even if you only have 1 item.

from spots.

@zenangst yeah, inspired by numberOfLines. I have preferred because it will not always be the number of lines we want, if we have too few items. But I 👍 with dropping preferred

from spots.

@vadymmarkov @JohnSundell what do you guys think about numberOfLines is that more descriptive than itemsPerRow ?

from spots.

@zenangst what's wrong with itemsPerRow? I find it pretty descriptive 🙂

from spots.

@JohnSundell I'm just afraid that it might be confused with vertical layouts where everything is per row. If this is what you think you would get by setting that property then it might not be an issue at all:

from spots.

yeah, I'm still using my silly example to show of the feature 😁

from spots.

What about columns 😄

from spots.

But columns are horizontal, what you are setting are the amount of rows per column... I think. This whole thing has gotten med confused ;)

from spots.

itemsPerColumn?

from spots.

Hm.. columns are vertical, rows are horizontal 🤔

from spots.

I edited my previous comment.

from spots.