Code Monkey home page Code Monkey logo

Comments (8)

shakeelmohamed avatar shakeelmohamed commented on August 16, 2024

See #35 (index.html and everything.js) for inspiration

from zen-audio-player.github.io.

shakeelmohamed avatar shakeelmohamed commented on August 16, 2024

How's this going @eirism? Just checking in, no need to panic 😼

from zen-audio-player.github.io.

eirism avatar eirism commented on August 16, 2024

The dev/timeseek branch has a working implementatipn of it. The excact behaviour and placement/looks of it may need to be tweaked.

from zen-audio-player.github.io.

shakeelmohamed avatar shakeelmohamed commented on August 16, 2024

Just tested this out, it works pretty well!

Leaving some notes here so I don't forget:

  • Change the setInterval() interval to a lower value, maybe 50ms instead of the current 100ms
  • The seek slider should be above the time display
  • We should try to visually distinguish the 2 sliders. Maybe make the volume one smaller? Maybe make the seek slider 400px wide? Maybe move the video times to either side of the slider, something like quicktime

from zen-audio-player.github.io.

shakeelmohamed avatar shakeelmohamed commented on August 16, 2024

More thoughts:

  • Maybe the volume slider should be more vertical, like YouTube
    screen shot 2016-01-12 at 10 43 33 am
  • Maybe the time seek slider should have a tooltip instead of having current time & duration on either side (leaving 00:00 / 00:01 where it is below the slider), see example 8
    screen shot 2016-01-12 at 10 44 15 am

from zen-audio-player.github.io.

eirism avatar eirism commented on August 16, 2024

We will need to install Bootstrap to use tooltips. For the volume slider, are you thinking of changing the circle for another icon? Sliders support unicode characters as handles, so if you find a suiting symbol we can use it.
Should the time tooltip be above or below the slider, and should it always be visible or only visible when hovering over/using it? Either way we will need to make space for the tooltip, so that it doesn't collide with the text around it.

from zen-audio-player.github.io.

shakeelmohamed avatar shakeelmohamed commented on August 16, 2024

Oh right, let's not pull in another UI dependency 😄

For the volume slider, are you thinking of changing the circle for another icon?

I played with the CSS a bit for the volume slider.
capturfiles_20
Obviously the selector will need to be more specific, but I think this visually looks close enough to a vertical line

.slider-handle {
    max-width: 3px;
}

Should the time tooltip be above or below the slider, and should it always be visible or only visible when hovering over/using it?

Let's try above, you can add a <br> or two for spacing

from zen-audio-player.github.io.

shakeelmohamed avatar shakeelmohamed commented on August 16, 2024

Done with #130

from zen-audio-player.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.