Code Monkey home page Code Monkey logo

Comments (4)

leoetlino avatar leoetlino commented on June 7, 2024

What build error do you get?

from oead.

neebyA avatar neebyA commented on June 7, 2024

Hi,
I ran into the same issue, and as this issue was already open, I thought I'd comment here in case it's still being worked on.

Here's the error I'm getting on Apple Silicon:

~> pip install oead
Collecting oead
  Using cached oead-1.2.6.post1.tar.gz (3.9 MB)
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: oead
  Building wheel for oead (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [67 lines of output]
      /Users/neeby/.repositories/clones/testing/BCML/venv/lib/python3.9/site-packages/setuptools/dist.py:529: UserWarning: Normalizing 'v1.2.6-1' to '1.2.6.post1'
        warnings.warn(tmpl.format(**locals()))
      running bdist_wheel
      running build
      running build_ext
      -- The CXX compiler identification is AppleClang 14.0.3.14030022
      -- Detecting CXX compiler ABI info
      -- Detecting CXX compiler ABI info - done
      -- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
      -- Detecting CXX compile features
      -- Detecting CXX compile features - done
      -- pybind11 v2.10.1
      -- Found PythonInterp: /Users/neeby/.repositories/clones/testing/BCML/venv/bin/python3.9 (found suitable version "3.9.16", minimum required is "3.6")
      -- Found PythonLibs: /opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.9/lib/libpython3.9.dylib
      -- Performing Test HAS_FLTO
      -- Performing Test HAS_FLTO - Success
      -- Performing Test HAS_FLTO_THIN
      -- Performing Test HAS_FLTO_THIN - Success
      CMake Error at CMakeLists.txt:46 (add_subdirectory):
        The source directory

          /private/var/folders/2x/yc3gqnh578n2xf585cps14h0bqshdy/T/pip-install-ajfd30z1/oead_12fe5fd52fa74af8b6c87bcde23d07b0

        does not contain a CMakeLists.txt file.

I'm able to install just fine by cloning this repository and then running pip install .. It's only the PyPI distribution that seems to be missing some required CMake files, and I was able to reproduce this issue on Linux by attempting to install the source tarball from PyPI rather than the built wheel.

I also downloaded the tarball from PyPI to see if there were any differences in the CMakeLists.txt files:

~> tar --list -f ~/Downloads/oead-1.2.6.post1.tar.gz | grep 'CMakeLists.txt$' | sort | sed 's/oead-1.2.6.post1/./g' > pypi_cmake.txt
~> find . -type f -name 'CMakeLists.txt' | sort > repo_cmake.txt
~> diff *cmake.txt
0a1
> ./CMakeLists.txt

It seems the root CMakeLists.txt is missing?

I tried manually adding the CMakeLists.txt file:

mkdir oead-1.2.6.post1 && cp CMakeLists.txt oead-1.2.6.post1/
gunzip ~/Downloads/oead-1.2.6.post1.tar.gz
tar -rf ~/Downloads/oead-1.2.6.post1.tar oead-1.2.6.post1/CMakeLists.txt
gzip ~/Downloads/oead-1.2.6.post1.tar
pip install ~/Downloads/oead-1.2.6.post1.tar.gz

but this gave more missing file errors for CMakeRC.cmake, then files from src/. It seems like the source tarball ought to contain a lot more files than it does

from oead.

leoetlino avatar leoetlino commented on June 7, 2024

Thanks for looking into this. Hmm that's annoying -- I wonder if we can tell the Python packaging code to just include every file instead of having to whitelist files in the manifest.

Please feel free to open a PR if you have a fix (even if it's just adding stuff to the whitelist). Otherwise you'll have to wait for me to be less busy :P

from oead.

neebyA avatar neebyA commented on June 7, 2024

Thanks, I messed around with the setup and manifest until I was able to get an installable sdist, so I opened #28

from oead.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.