Code Monkey home page Code Monkey logo

Comments (3)

CrystalWindSnake avatar CrystalWindSnake commented on June 11, 2024 2

I'd suggest to simply change the name instead of the stem. This shouldn't make a difference, since the suffix ".json" doesn't contain "-" or "_" anyway. And with_name is available in Python 3.8.

So we can simply replace

new_filepath = filepath.with_stem(filepath.stem.replace('_', '-'))

with

new_filepath = filepath.with_name(filepath.name.replace('_', '-'))

@CrystalWindSnake Let us know if you want to post a PR or if we should fix it ourselves. We're fine with both. 🙂

I will gladly create a pull request

from nicegui.

rodja avatar rodja commented on June 11, 2024

Ok. How would we need to code this for Python 3.8 compatibility? Would you like to create a pull request?

from nicegui.

falkoschindler avatar falkoschindler commented on June 11, 2024

I'd suggest to simply change the name instead of the stem. This shouldn't make a difference, since the suffix ".json" doesn't contain "-" or "_" anyway. And with_name is available in Python 3.8.

So we can simply replace

new_filepath = filepath.with_stem(filepath.stem.replace('_', '-'))

with

new_filepath = filepath.with_name(filepath.name.replace('_', '-'))

@CrystalWindSnake Let us know if you want to post a PR or if we should fix it ourselves. We're fine with both. 🙂

from nicegui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.