Comments (4)
Eek sorry I see what you’re saying, I was talking about in zarf init. For regenerate we should make the ui consistent and prompt like init does eventually but for now just leaving as a required (no default value) flag is probably fine.
from zarf.
36: pkiRegenerate.Flags().StringVar(&pkiOptions.Host, "host", "zarf-server", "Specify the host or IP for the gitops service ingress")
37: _ = pkiRegenerate.MarkFlagRequired("host")
https://github.com/defenseunicorns/zarf/blob/master/cli/cmd/pki.go#L36 defines the --host flag as having a default of zarf-server
but then also marks the flag as required making it so a user would have to manually put a host no matter what.
This is would be confusing for new (or non-technical) users since cobra compiles the help docs from zarf pki regenerate --help
to say --host string Specify the host or IP for the gitops service ingress (default "zarf-server")
which implies you don't need to do anything.
Do we want "zarf-server" to actually be a default or do we want to force the user to pass in their own value for the flag?
from zarf.
Actually neither. It’s a bit funkier than that. That’s just legacy code we can probably remove. There are cases where a host isn’t needed at all—such as when you provide your own tls keypair. I think the best thing for now would be to drop the required flag (if it’s required) and the default value. They should still be prompted. Eventually I’d like to not ask for the host name if they aren’t generating pki.
from zarf.
Just to make sure I'm 100% following, the required flag I pointed out was for the ./zarf pki regenerate
command. Farther along in the code it uses the hostname to generate the cert. Are you saying it's okay if the hostname is an empty string at this point?
from zarf.
Related Issues (20)
- Consider alternative options to port-forwarding from localhost to access Zarf cluster resources HOT 1
- Detect Invalid Helm Release Names Before Deployment HOT 1
- Pre package pull check HOT 4
- helm override variables are limited to strings
- Refactor the types to clean up json / jsonschema tags HOT 1
- Move JSON schema generation
- Cannot update sigstore/cosign version
- Integrate Sigstore for "keyless signing" of packages and their build provenence HOT 1
- Wildcards when support using K8s manifests HOT 1
- Refactor helm embedding when/if a better solution becomes available
- test flake: TestExtInClusterTestSuite
- test flake: validate-k3s times out after 35 minutes HOT 2
- Replace custom retry logic with a single retry function HOT 2
- test flake: failed to publish package during nightly eks
- Create and implement v1beta1 schema
- Move dos-games example to it's own repo
- Image Race Condition Between Zarf Seed Registry and Zarf Permanent Registry With Multiple Registry Replicas
- Break apart `--insecure`
- Very large docker containers fail with BLOB_UPLOAD_INVALID
- Allow `zarf dev find-images` update `zarf.yaml` with discovered images
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zarf.