Comments (14)
I ask my boss if I can get a budget for this.
from zest.
I'm +1 to the change, but worth noting that it will break binary compatibility (if we completely drop Commons HttpClient).
from zest.
+1 as well.
Do we really need binary compatibility?
Zest script compatibility is the important thing to maintain :)
from zest.
Well, this change will break (ZAP) Zest add-on, but not a problem we can update it easily :)
from zest.
Zest script compatibility is the important thing to maintain :)
I can run the same Zest scripts than before the change. org.mozilla.zest.core.v1.ZestRequest works with class Cookie from the Apache HTTP Client 4.5.5.
This is possible because JSON from the Class Cookie from HTTP Client 3.1 can be de-serialised in to objects of the class Cookie in the Apache HTTP Client 4.5.5.
Everything else in the package org.mozilla.zest.core.v1 was not changed.
from zest.
The changes took place in the class org.mozilla.zest.impl.ZestBasicRunner. There are some bigger changes because before migration to HTTP Client 4 I isolated all methods from this class using the HTTP Client 3 in a new class. ZestBasicRunner holds an interface of this class which gets an instance of the new class at runtime. This makes further migrations (Apache HTTP Client 5 is in the beta version) easier.
from zest.
Which version/commit are you basing your work on? Asking because #118 refactored ZestBasicRunner
to allow that.
from zest.
I did the migration on the master branch. I have checked #118. That looks good. You have already done an important part of the work.
A) ZestCookie: Good idea. Makes Zest independent from particular HTTP clients.
B) org.mozilla.zest.impl.CommonsHttpClient implements ZestHttpClient: Almost the same as my approach. I think I can begin. Have to ask for procedure/budget first.
from zest.
Note that the work should be done in the develop
branch (master
is being used only for tagging releases).
Cool, let us know how that goes.
from zest.
Of course, in the develop branch.
from zest.
I did the work and made the pull request #171
from zest.
Tests were done successfully by running examples/BodgeIt_Register_XSS.zst against a dummy service so I could check the requests made by the zest runner.
from zest.
Do you plan to include the new HTTP client for the next release?
from zest.
Sure, good to get this change in (added to milestone).
from zest.
Related Issues (20)
- Trouble running CLI HOT 3
- Zest script to disable or click on a prompt dialog box on Chrome HOT 8
- Update Selenium HOT 2
- Add changelog file
- Reporting
- Commandline Interface programming
- Wiki changes
- Release to Maven Central HOT 1
- CODE_OF_CONDUCT.md file missing
- Can't tell if an assertion has been violated from CLI's output
- Add a `ZestClient...` `elementType` to wait a certain time before running the next statement HOT 5
- Zest Script Ignores followRedirects HOT 1
- Adding new feature to select HTML drop down list options HOT 1
- Add support for commands such as scrolling and hovering over client element
- Replace `gson` with `Jackson`
- Add `trimWhitespace` parameter for String related statements HOT 1
- Interaction with Alert Boxes HOT 2
- Converting Fiddler’s “saz” recordings to ZEST’s “zst” files HOT 2
- Parameter UrlEncoding in Request Body HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zest.