Code Monkey home page Code Monkey logo

Comments (2)

elgalu avatar elgalu commented on September 5, 2024

This makes me worry which is the right place to do this, let's analyze some workflow:

  1. User writes deploy in a PR comment
  2. Zappr server process this deploy comment and POST to Github depl endpoint.

Reading the docs we see:

GitHub then dispatches deployment events that external services can listen for and act on.

In this sentence, external services would likely be our CD tool, namely Jenkins/GoCD/Travis/...

My question would be, why not directly send the event from Zappr to our CD tool?

But if external services is still Zappr then this feature makes more sense and so does #105 however that implies adding CD features into Zappr, namely deploy commands reports (Jenkins: console outpus), deploy job scheduling (Jenkins: executors), deployment access control, i.e. application write all scopes and so on...

from zappr.

prayerslayer avatar prayerslayer commented on September 5, 2024

Closing as I feel this is out of scope for Zappr.

from zappr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.