Comments (2)
This makes me worry which is the right place to do this, let's analyze some workflow:
- User writes deploy in a PR comment
- Zappr server process this deploy comment and POST to Github depl endpoint.
Reading the docs we see:
GitHub then dispatches deployment events that external services can listen for and act on.
In this sentence, external services would likely be our CD tool, namely Jenkins/GoCD/Travis/...
My question would be, why not directly send the event from Zappr to our CD tool?
But if external services is still Zappr then this feature makes more sense and so does #105 however that implies adding CD features into Zappr, namely deploy commands reports (Jenkins: console outpus), deploy job scheduling (Jenkins: executors), deployment access control, i.e. application write all scopes and so on...
from zappr.
Closing as I feel this is out of scope for Zappr.
from zappr.
Related Issues (20)
- readthedocs header hides parts of documentation HOT 3
- Making Zappr Github Marketplace ready. HOT 2
- add 503 API errors to trouble shooting section
- Accept webhook url as a config parameter HOT 4
- OneOf Labels Check HOT 5
- Support Label based approver group conditions
- Mandate 'contains-issue-number' in PR's body HOT 1
- Zappr fails on (?:(?i)AND)(?:-|\s)\d+ commit msg pattern HOT 2
- Quiz about Authorization Callback URL HOT 3
- Zappr incorrectly reports a check was enabled by a user
- Approval/veto regexes only work for start of comment HOT 1
- Add prettier to the project.
- Ignore "pull request tasks check" for specified checkboxes
- User-defined regex patterns for specification body options `contains-issue-number` and `contains-url`
- Effective config `specification.title.minimum-length` has property `enablead`
- Incorrectly reported failed check name 'contains-issue-number'
- "Update this Branch" should not require approvals again
- Zappr does not response
- Unexpected rejection of the PR title: "PR's title is too short (8/8)"
- Builds are failing since December, 6th
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zappr.