Code Monkey home page Code Monkey logo

Comments (3)

nolar avatar nolar commented on August 19, 2024

Thanks for reporting.

It seems like improper phrasing in the logs. The logic is as intended.

kopf.PermanentError (aliased as legacy kopf.HandlerFatalError) tells the framework to give up on this specific handler, and never retry it again. Once it is raised —assuming it is the only handler— there are no more handlers to try either now or later, including this same failed handler's retries, and so the handling cycle ends.

This is marked by a phrase "all handlers succeeded" meaning that "all handlers have been tried and all of them have done what they could and I have nothing to do and bye-bye". This is the opposite to the case when there are handlers left to try/retry later until this handling cycle is finished.

A "handling cycle" is an internal term for full processing of a single cause (creation, update, deletion) with all matching handlers. I'm not sure if the "handling cycle" term should be exposed to the user.

I would be happy if you suggest a better phrasing that makes it more clear and less confusing.

from kopf.

moltzaum avatar moltzaum commented on August 19, 2024

Supposing the response is not conditional I think it is slightly better phrasing to simply say: All handlers finished for creation or All handlers completed for creation. Or since not 'all' handlers may be run, just drop the 'all'.

But I do think it should have conditional phrasing. I think omission works since there is a previous message that says what failed. If an explicit message is still wanted though, maybe: Handlers for creation aborted

from kopf.

nolar avatar nolar commented on August 19, 2024

Solved nolar/kopf#540, available since kopf>=0.28rc2

from kopf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.