Comments (3)
This sounds pretty tricky to implement for all the different refactoring rules, so I'd prefer to fix shed when it gets something wrong instead.
(although note also that this is a side project to my main OSS volunteering, so no guarantees of timely fixes unless someone else volunteers to write them)
from shed.
Hi @Zac-HD,
The thing that Shed gets wrong for me is sqlalchemycriteria: These are often expressed as:
objectname.columname == True
Which shed will refactor as:
objectnae.columname is True
Which doesn't have quite the same meaning, and will break SQLAlchemy. I've had to switch off refactor to prevent this from breaking.
from shed.
I've opened an issue to make sure that this doesn't get forgotten before someone volunteers to fix it 🙂
from shed.
Related Issues (20)
- Should the readme list >=py38 instead of >=py37 as the autodetected minimum version? HOT 2
- Replacing ~autoflake, isort, and~ black with Ruff HOT 9
- Enable more ruff autofixes
- Refactor type hints for Python 3.10+ HOT 7
- Stop `shed --refactor` from removing comments in otherwise-pointless parens
- Incorrect refactor when removing nested `sorted`
- add upper bound for black and isort versions HOT 5
- `shed --refactor` should only convert `== True` to `is True` within an `if` or `while` HOT 5
- Shed requires two passes when removing imports makes it possible to put them on one line HOT 2
- Shed requiring two passes when removing import causes ordering confusion HOT 4
- Replacement of `reversed(sorted(x))` with `sorted(x, reverse=True)` changes stability of sort. HOT 4
- Bugs in `shed --refactor`
- [feature request] some way of passing through options/config to bundled tools HOT 2
- After next `autoflake` release, grab the perf improvement HOT 3
- Coding magic comment deleted HOT 1
- shed --refactor breaks on (incorrect) code involving generator expression HOT 4
- Complicated regex somehow breaks shed --refactor HOT 1
- Proposal: shed should use ast.parse to validate code on errors HOT 4
- `docshed` should only apply in docstrings, not other string literals HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shed.