Code Monkey home page Code Monkey logo

Comments (4)

suborb avatar suborb commented on May 28, 2024

Is this just a cunning ruse to test out the tagged docker pipeline?

In all seriousness, I'm not particularly keen on doing a release of 2.2.1:

  • There are some real clangers in 2.3 that are arguably higher priority
  • Building all the artefacts manually will be time consuming for me (the nightly machine is just setup to track master)

However, if it fits in with your workflow, I can create a release-2.2 branch, that commit can be cherry-picked in (and probably fixed up) and you can pull that branch and build locally.

from z88dk.

jorgegv avatar jorgegv commented on May 28, 2024

Oh, never mind for me, I have already documented it for myself and I already fixed Cesare to compile with 2.3 (with 2.3 a binary took just 2 bytes more than 2.2, and it broke my build!)

I thought making a 2.2.1 release and image would be simple, since it's only a one time job, fire and forget.

Point is, 2.2 will cease to compile in any up to date machine in the near future... Fedora has been among the first to update the compiler, but the rest will follow shortly.

from z88dk.

suborb avatar suborb commented on May 28, 2024

I thought making a 2.2.1 release and image would be simple, since it's only a one time job, fire and forget.

For a regular release it is! I just promote the last nightly.

Point is, 2.2 will cease to compile in any up to date machine in the near future... Fedora has been among the first to update the compiler, but the rest will follow shortly.

I can reproduce that issue here now, but doing export CFLAGS=-Wno-int-conversion before compiling does I think match the previous behaviour.

If it becomes a bigger problem, I'll revisit of course.

from z88dk.

jorgegv avatar jorgegv commented on May 28, 2024

Ah, I see. So you'll just document somewhere that if you have this problem when compiling 2.2, you can just add your workaround and retry. Easier than putting out a new release.

This does not solve the bug in that line (fields are incorrectly initialized in that structure from that field to the end), but I guess if no one has noticed until now, that probably means not many people are compiling ZXN code with 2.2 any more...

Thanks for the explanations. I added a note with your workaround on the installation page, see: https://github.com/z88dk/z88dk/wiki/installation#special-note-on-22

from z88dk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.