Code Monkey home page Code Monkey logo

Comments (8)

z411 avatar z411 commented on July 21, 2024

Thanks for the report. It seems the results of fuzzy search are becoming apparent.

Can you please give me the filenames of the episodes that get mixed up?

from trackma.

SleepyMan avatar SleepyMan commented on July 21, 2024

Well, it's simply because HorribleSubs uses Mahouka as its name, while the official MAL name is "Mahouka Koukou no Rettousei". Making a fuzzy search on alternative titles as well as official titles make this a non-issue, as Mahouka is listed in its alt titles.

from trackma.

z411 avatar z411 commented on July 21, 2024

as Mahouka is listed in its alt titles

Which service are you using? MAL doesn't list it as an alternative title.

<series_animedb_id>20785</series_animedb_id>
<series_title>Mahouka Koukou no Rettousei</series_title>
<series_synonyms>; The irregular at magic high school</series_synonyms>

from trackma.

SleepyMan avatar SleepyMan commented on July 21, 2024

Wow, sorry, it really isn't. This is weird, since I modified engine.py to compare to the alternative titles before, it was recognizing it correctly, so I assumed it was in its alternative titles.

Edit: Well, we could add a small amount to the ratio if the file contains a substring of the title/alt-title. E.g. add 0.5 to the ratio if the filename is contained in the title ("Mahouka" in "Mahouka Koukou no Rettousei" or "Argevollen" in "Shirogane no Ishi: Argevollen").

from trackma.

Asnanon avatar Asnanon commented on July 21, 2024

Sorry about the delay, the file in question was [HorribleSubs] Mahouka - 12 [720p].mkv, which the search indicated as new Hyouka episode.
There are no problems whatsoever with the recognition of Mahouka. Just the similarity of Houyka and Mahouka seems to produce some errors.
On a related note series that have specials have a similar problem, the episodes of the main series get recognized as special episodes eventhough nothing in the name indicates anything about being a special episode.

from trackma.

z411 avatar z411 commented on July 21, 2024

I see. Since "Mahouka" isn't listed as an alternative by the MAL database, even if I tried to remedy this the tracker, instead of confusing it with Hyouka, it just wouldn't find it at all.

The best thing you can do is to set "Mahouka" as the alternative title yourself (can be done in wmal-qt by selecting the show, and going into Show -> Set alternative title), which is a workaround for these specific cases.

The tracker uses a ratio number (currently 0.7) for the fuzzy search. The higher the number is, the stricter the fuzzy search is. I'm hesitant about increasing this number as it might produce problems with other legitimate matches, so the best thing I can do here is to make this number configurable, which I will do.

About the specials issue, I'll look into this, and I think #61 might help.

from trackma.

Asnanon avatar Asnanon commented on July 21, 2024

Sadly that didn't work either.
Using the qt interface the setting of an alternative title worked,
although the Mahouka episode still gets recognized as Hyouka episode.
Might be the limit of recognition I guess when two names are too similar
just like in this case. Or as mentioned before with specials.
Makes me personally a bit curious what happens with series that have
longer names which are similar since Ore, Kore, Demo etc. are fairly
popular words to be used lately, especially in LN adaptions.

from trackma.

Argon- avatar Argon- commented on July 21, 2024

Some time ago I thought about a dynamic ratio, adjusting itself based on the length of the file name (the shorter the name, the higher/stricter the ratio) to avoid having too much false positives (Mahouka <-> Hyouka) but I never tested this.

from trackma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.