Code Monkey home page Code Monkey logo

Comments (5)

chupocro avatar chupocro commented on June 4, 2024 1

Hi again :-) Setting the environemnt variable set NO_COLOR=1 solved the problem while the switch --color=off, as you suspected, didn't.

from sjasmplus.

ped7g avatar ped7g commented on June 4, 2024

can you try sjasmplus --color=off to get DISPLAY without color codes, if that helps with arrows, but I don't expect the main issue to be related to ANSI color codes, so I expect the color off to not help. Would be nice if you can confirm it, as I don't have any windows machine to try myself.

from sjasmplus.

ped7g avatar ped7g commented on June 4, 2024

oh, looking into the code, that will turn colors off, but still tamper with console settings, so if you can try also other experiment with setting environment NO_COLOR (to any value, just have to exist) before running sjasmplus, and then see if that does affect behaviour. Thank you.

from sjasmplus.

ped7g avatar ped7g commented on June 4, 2024

so the issue is this code (which is used to enable ANSI color codes in windows cmd.exe):
https://github.com/z00m128/sjasmplus/blob/master/sjasm/support.cpp#L147-L149

issue is known and "by design":
microsoft/terminal#4949

so the remaining question is whether I want to care and try to un-set the virtual input processing before exiting sjasmplus (shouldn't be too hard in case of clean exit, in case of fatal error it may require extra call in code to cleanup in such case too), or I will tag this as wont-fix and suggest to use more modern OS like some linux.

from sjasmplus.

ped7g avatar ped7g commented on June 4, 2024

I did try to add console mode restoration in windows upon sjasmplus exit. As I have no means to test what this change does, it may fix things or it may make them worse...

If you can build the master branch yourself and verify the fix works (and the ANSI colors still work, ie. DISPLAY is teal), I will be thankful, otherwise this will go out untested with next release, which I have right now no plans to do any time soon.

With current sjasmplus release you can also use NO_COLOR environment variable, although I would once more suggest to switch OS, as MS windows will very likely become more and more tedious to support over time.

from sjasmplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.