Drop PyYAML dependency about python-text-distance HOT 4 CLOSED

That makes sense, will remove the dependencies in next version.

from python-text-distance.

Thanks for the suggestion. The reason for having a logging config file is to make it easy to control logging for all modules in one place so I think we should keep the logger config file.

However logging also supports json as its config file so one workaround will be to rewrite the logging config file into a json which can be read using Python built-in library.

from python-text-distance.

I still think it should be the apps authors responsibility. Config file is not the best option for everybody. e. g.:

• a CLI tool might want to vary its config settings based on how many -v switches it got
• a GUI application might log into its UI and allow users to change logging settings on the fly
• a Twelve-Factor proponent could prefer to store the whole config in the environment – not that it makes too much sense if there are two or three deploy variations, but some people do that :)

I'd say this code

with open(logger_config_yaml_path, "rt") as f:
    config = yaml.safe_load(f.read())
logging.config.dictConfig(config)

belongs in the application itself as it's way too specific.

from python-text-distance.

Changes made per suggested, thanks again for suggestion.

from python-text-distance.