Comments (2)
So what I have done is this:
const vows = [];
_.eachDeep(filters, (val, key, parent, ctx) => {
// ...
vows.push(someAsyncFn(val).then(res=>parent[key] = res);
}, { leavesOnly: true, checkCircular: true });
await Promise.all(vows)
I wish this could be done internally. You see the ...deep functions just have to detect if the callback is an async function, and do exactly like above before returning the modified obj. They do the then
and setting of the parent[key]
.
Detection of async function and vow keeping can be achieved like so:
if (cb instanceof Object.getPrototypeOf(async function () {}).constructor) {
vows.push(cb(value, key, parent, ctx).then(res => parent[key] = res));
} else {
parent[key] = cb(value, key, parent, ctx); // normal callback function
}
// ... then finally, before we return everything we return a promise that awaits the vows, but resolves to the object
return Promise.all(vows).then(res=>originalObjWeWereIterating)
That will allow the functions to be used like so:
filters = await _.eachDeep(filters, async (val, key, parent, ctx) => {
// ...
return parent[key] = await someAsyncFn(val);
}, { leavesOnly: true, checkCircular: true });
it won't change semantics, but enhance the lib to work with promises.
from deepdash.
Hi @emahuni - your implementation is 100% valid and if I would need to do it I would do the same.
Still it makes no sense to support it in deepdash internally: rare use case, but performance will be affected in all cases.
from deepdash.
Related Issues (20)
- omitDeep changes input on empty array HOT 1
- omitDeep doesn't omit objects HOT 7
- ERR_PACKAGE_PATH_NOT_EXPORTED HOT 3
- how to remove values from json if they exist
- Feature Request Parent path
- filterDeep not working on deeply nested object HOT 2
- Frustrating that things like `pickDeep` and `filterDeep` can only return a nested structure HOT 3
- deepdash-es not working with jest-resolve HOT 9
- deepFilter keep parents
- ESM: IIterateeContext typescript interface not exposed
- findPathDeep doesn't return first Value path
- findDeep or findDeepValue - Return object that contains the key & value
- eachDeep with childrenPath == wrong parent, parent path etc
- Bug in documentation _.findDeep*
- findDeep return types problem HOT 3
- Add contributing docs HOT 1
- findDeep is not a function HOT 1
- explicit return values, why and how does this work HOT 1
- mapValuesDeep mutates the original object if `leavesOnly: false` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deepdash.