Code Monkey home page Code Monkey logo

Comments (6)

kemenaran avatar kemenaran commented on July 25, 2024

Thanks for the feedback @opi!

Sure, I can do that. I had a feeling that Yunohost apps had a tendency to include the app sources inside the app package; but maybe it's not that reasonable when it includes binaries, indeed.

(For the record, I initially misread your comment, and thought you wanted to compile the binaries from source on the machine. I have long notes to explain this, but out they go :)

from mattermost_ynh.

opi avatar opi commented on July 25, 2024

You're right about that tendency, it's an old one, and we try to move away from that ! You know, security is a process ... ;)

from mattermost_ynh.

kemenaran avatar kemenaran commented on July 25, 2024

This should be fixed ; binary release is now downloaded at install-time.

from mattermost_ynh.

opi avatar opi commented on July 25, 2024

Oh great !!

As your app is still in development and without a huge user base, I wonder if it's not a good time to get rid of some git history to avoid downloading a huge repo during git clone while installing.

Maybe it's not a good idea, but playing with git rebase could help us remove the commit that add mattermost source.

from mattermost_ynh.

kemenaran avatar kemenaran commented on July 25, 2024

Good idea ; I've just done that, using git-filter-branch to remove the sources directory from the git history.

The repo size is now 12 Ko ; not bad :)

from mattermost_ynh.

opi avatar opi commented on July 25, 2024

So good, thanks for your work !

from mattermost_ynh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.