CSS - Don't strip spacing before !important about yuicompressor HOT 9 CLOSED

If you consider Outlook 2007 a browser then good for you. 👍

from yuicompressor.

This was merged into 2.4.8

from yuicompressor.

@tml @namanyayg Could you provide any examples where stripping a space before '!important' leads to a broken styling?

We got the similar request in https://github.com/GoalSmashers/clean-css but without a test case it's not possible to verify if you made a mistake or if there is a very specific case where the space has to be there.

According to our tests it is OK to get rid of it. What's more such code has been used in production for couple years now without any issues.

from yuicompressor.

Can we get some background or data on this, or revert the change? Without any more information, this seems like a needless regression. We've also been using 2.4.7 for a while now in production without issue.

from yuicompressor.

I can confirm that this space is important in some browsers / mail clients.

Outlook 2007 is definitely effected by this.

from yuicompressor.

Also, although its not in the spec that a space should be present, all of their examples have it.
http://www.w3.org/TR/CSS2/cascade.html#important-rules

from yuicompressor.

So you punish all other browsers because of Outlook 2007?

from yuicompressor.

Yes. And punish? Hardly. The rule shouldn't really be used anyway. But its required to fix bad implementations of browers etc. eg. Outlook 2007 etc.

from yuicompressor.

@GoalSmashers Really? I even stated bad implementations of browsers.

Outlook makes up for a huge percentage of the mail client market share.

from yuicompressor.